perf(load): defer findWASM until native binary is missing#78
Merged
Conversation
Call findWASM only when find() returns no native .node, so we skip unnecessary prebuilds readdir when a native build is available.
Overall package sizeSelf size: 37.28 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
szegedi
approved these changes
Mar 3, 2026
tlhunter
pushed a commit
that referenced
this pull request
Mar 19, 2026
Call findWASM only when find() returns no native .node, so we skip unnecessary prebuilds readdir when a native build is available.
tlhunter
pushed a commit
that referenced
this pull request
Mar 20, 2026
Call findWASM only when find() returns no native .node, so we skip unnecessary prebuilds readdir when a native build is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes the native/WASM loader in
load.jsso we only look for a WASM build when no native.nodebinary is found.Changes
load(),findWASM(name)is now called only whenfind(name)returns nothing. Previously both were always run, so when a native prebuild existed we still did the extrareaddirSyncand path logic for the WASM prebuilds folder. This removes that unnecessary work on the common path where a native binary is available.