chore(ci): add test-js job to run Node tests after build#81
Closed
chore(ci): add test-js job to run Node tests after build#81
Conversation
Introduce a test-js job in the build workflow that runs on ubuntu-latest after the build job, checks out the repo, downloads artifacts, sets up Node.js, installs deps with yarn, and runs yarn test.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
test-jsjob to the Build workflow so Node/JS tests run in CI after the native addon build.Motivation
The workflow builds native addons and runs package-size checks but did not run
yarn test. The new job runs the JS test suite on the built artifacts so test failures are caught in CI.Changes
.github/workflows/build.yml: Newtest-jsjob that depends onbuild, checks out the repo, downloads build artifacts, sets up Node.js, runsyarn installandyarn testonubuntu-latest.