test(crashtracker): fix flaky test on Alpine#83
Merged
Conversation
szegedi
reviewed
Mar 3, 2026
Contributor
szegedi
left a comment
szegedi
left a comment
There was a problem hiding this comment.
Empirically, the timeout is still a tad low – alpine targets 20-25 succeeded now on the first try, but 16 and 18 still failed. One retry made 18 succeed, but 16 still failed. I'm now re-running 16 again. Maybe bump to 30s?
watson
force-pushed
the
watson/increase-test-timeout
branch
from
514e63e to
6f65717
Compare
watson
force-pushed
the
watson/increase-test-timeout
branch
4 times, most recently
from
fc112f6 to
3661240
Compare
Overall package sizeSelf size: 37.33 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Timeout was hitting in CI; tests may just need more time. Bumping from 10s to 20s to reduce flakiness. If the root cause is a race where a test hangs, a higher timeout alone won't fix it.
The crashtracker-receiver creates stdout.log and stderr.log, but if it never starts, these files won't exist. The timeout handler previously called `cat` unconditionally, which threw an error that masked the actual timeout message.
Previously, `runApp` ignored child process failures, causing the test to silently hang until the timeout. Now the promise rejects on spawn errors and on child exit when no crash report is received (after a 5s grace period).
The crashtracker signal handler's 3s timeout budget was too short for in-process symbol resolution (blazesym) on Alpine under CI resource pressure, causing the handler to silently abandon crash reports before they could be sent.
watson
force-pushed
the
watson/increase-test-timeout
branch
from
3661240 to
d765b85
Compare
watson
changed the title
It needs to be higher than 15 sec
watson
force-pushed
the
watson/increase-test-timeout
branch
from
8e5975c to
28eb001
Compare
gyuheon0h
approved these changes
Mar 3, 2026
tlhunter
pushed a commit
that referenced
this pull request
Mar 19, 2026
…sts (#83) - Increase crashtracker handler timeout from 3s to 15s and crash-report wait timeout from 10s to 20s to reduce flakiness in CI - Guard stdout/stderr log file reads in the timeout handler with existence checks to avoid masking the real timeout error - Add error and close handlers to child processes so tests fail with a clear message instead of hanging indefinitely - Add console.log labels to each test for easier debugging
tlhunter
pushed a commit
that referenced
this pull request
Mar 20, 2026
…sts (#83) - Increase crashtracker handler timeout from 3s to 15s and crash-report wait timeout from 10s to 20s to reduce flakiness in CI - Guard stdout/stderr log file reads in the timeout handler with existence checks to avoid masking the real timeout error - Add error and close handlers to child processes so tests fail with a clear message instead of hanging indefinitely - Add console.log labels to each test for easier debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.