chore(ddtelemetry): migrate from RawTable to HashTable API#1009
Merged
morrisonlevi merged 5 commits intomainfrom Apr 8, 2025
Merged
chore(ddtelemetry): migrate from RawTable to HashTable API#1009morrisonlevi merged 5 commits intomainfrom
morrisonlevi merged 5 commits intomainfrom
Conversation
Update the QueueHashMap implementation to use the newer, more stable HashTable API from hashbrown. This change maintains the same functionality while using the recommended API.
Update hashbrown dependency to v0.15 and fix DefaultHashBuilder import path. The raw feature is no longer needed since we migrated to the hash_table module.
BenchmarksComparisonBenchmark execution time: 2025-04-08 19:54:34 Comparing candidate commit 0d78dd1 in PR branch Found 10 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/ 3782-8224-6310-005
scenario:credit_card/is_card_number/ 378282246310005
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/x371413321323331
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
paullegranddc
approved these changes
Apr 8, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
+ Coverage 71.47% 71.56% +0.09%
==========================================
Files 337 337
Lines 50509 50511 +2
==========================================
+ Hits 36099 36150 +51
+ Misses 14410 14361 -49
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Contributor
Author
|
I'm going to force merge this. The failing job is getting stuck uploading to GHA (for hours): I've seen this in other PRs, so not going to block here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the QueueHashMap implementation to use the newer, more stable
HashTable API from hashbrown. This change maintains the same
functionality while using the recommended API... I think.
Update hashbrown dependency to v0.15 and fix DefaultHashBuilder import
path. The raw feature is no longer needed since we migrated to the
hash_table module.
Motivation
I was looking at upgrading hashbrown and noticed this old API usage
which is problematic.
Additional Notes
I did this migration with the help of Cursor. The tests pass, and the code
changes do seem logical.
How to test the change?
cargo testof course, but I'm not sure if the existing tests arecomprehensive enough. Now would be a good time to add them if needed.