Skip to content

feat(data-pipeline): allow submitting Vec<Vec<Span>> asynchronously #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dd-mergequeue merged 1 commit into from
Jan 12, 2026
Merged

feat(data-pipeline): allow submitting Vec<Vec<Span>> asynchronously #1302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions libdd-data-pipeline/src/trace_exporter/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,24 @@ impl TraceExporter {
trace_chunks: Vec<Vec<Span<T>>>,
) -> Result<AgentResponse, TraceExporterError> {
self.check_agent_info();
self.send_trace_chunks_inner(trace_chunks)
self.runtime()?
.block_on(async { self.send_trace_chunks_inner(trace_chunks).await })
}

/// Send a list of trace chunks to the agent, asynchronously
///
/// # Arguments
/// * trace_chunks: A list of trace chunks. Each trace chunk is a list of spans.
///
/// # Returns
/// * Ok(String): The response from the agent
/// * Err(TraceExporterError): An error detailing what went wrong in the process
pub async fn send_trace_chunks_async<T: SpanText>(
Copy link
Copy Markdown
Contributor

@VianneyRuhlmann VianneyRuhlmann Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to keep all public functions documented with rustdoc

&self,
trace_chunks: Vec<Vec<Span<T>>>,
) -> Result<AgentResponse, TraceExporterError> {
self.check_agent_info();
self.send_trace_chunks_inner(trace_chunks).await
}

/// Deserializes, processes and sends trace chunks to the agent
Expand Down Expand Up @@ -622,7 +639,8 @@ impl TraceExporter {
None,
);

self.send_trace_chunks_inner(traces)
self.runtime()?
.block_on(async { self.send_trace_chunks_inner(traces).await })
}

/// Send traces payload to agent with retry and telemetry reporting
Expand Down Expand Up @@ -669,7 +687,7 @@ impl TraceExporter {
self.handle_send_result(result, chunks, payload_len).await
}

fn send_trace_chunks_inner<T: SpanText>(
async fn send_trace_chunks_inner<T: SpanText>(
&self,
mut traces: Vec<Vec<Span<T>>>,
) -> Result<AgentResponse, TraceExporterError> {
Expand All @@ -694,15 +712,13 @@ impl TraceExporter {
..self.endpoint.clone()
};

self.runtime()?.block_on(async {
self.send_traces_with_telemetry(
&endpoint,
prepared.data,
prepared.headers,
prepared.chunk_count,
)
.await
})
self.send_traces_with_telemetry(
&endpoint,
prepared.data,
prepared.headers,
prepared.chunk_count,
)
.await
}

/// Handle the result of sending traces to the agent
Expand Down
Loading