-
Notifications
You must be signed in to change notification settings - Fork 19
feat(profiling): Set and StringSet #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a3e2149
feat(profiling): Set and StringSet
morrisonlevi fb2ff6f
Reduce PR size
morrisonlevi c0ec8d8
docs: clarify safety comment
morrisonlevi 2fa9b0b
Merge branch 'main' into levi/collections
morrisonlevi b6a9687
build: fix lock and license file after merge
morrisonlevi 71d7981
Merge branch 'main' into levi/collections
morrisonlevi 5a05da5
Merge branch 'main' into levi/collections
morrisonlevi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,4 +12,4 @@ pub mod exporter; | |
| pub mod internal; | ||
| pub mod iter; | ||
| pub mod pprof; | ||
| mod profiles; | ||
| pub mod profiles; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright 2025-Present Datadog, Inc. https://www.datadoghq.com/ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| #[repr(C)] | ||
| #[derive(Debug, thiserror::Error)] | ||
| pub enum SetError { | ||
| #[error("set error: invalid argument")] | ||
| InvalidArgument, | ||
| #[error("set error: out of memory")] | ||
| OutOfMemory, | ||
| } | ||
|
|
||
| impl From<libdd_alloc::AllocError> for SetError { | ||
| fn from(_: libdd_alloc::AllocError) -> Self { | ||
| SetError::OutOfMemory | ||
| } | ||
| } | ||
|
|
||
| impl From<std::collections::TryReserveError> for SetError { | ||
| fn from(_: std::collections::TryReserveError) -> Self { | ||
| SetError::OutOfMemory | ||
| } | ||
| } | ||
|
|
||
| impl From<hashbrown::TryReserveError> for SetError { | ||
| fn from(_: hashbrown::TryReserveError) -> Self { | ||
| SetError::OutOfMemory | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| // Copyright 2025-Present Datadog, Inc. https://www.datadoghq.com/ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| mod error; | ||
| mod set; | ||
| mod slice_set; | ||
| mod string_set; | ||
| mod thin_str; | ||
|
|
||
| pub type SetHasher = core::hash::BuildHasherDefault<rustc_hash::FxHasher>; | ||
|
|
||
| pub use error::*; | ||
| pub use set::*; | ||
| pub use slice_set::*; | ||
| pub use string_set::*; | ||
| pub use thin_str::*; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file fix warnings under miri. Not the UB kind of warnings, just regular clippy style warnings.