Skip to content

Don't panic if CryptoProvider already installed #1391

Merged
dd-mergequeue[bot] merged 3 commits intomainfrom
jwiriath/fix-rustls-cryptoprovider
Dec 10, 2025
Merged

Don't panic if CryptoProvider already installed #1391
dd-mergequeue[bot] merged 3 commits intomainfrom
jwiriath/fix-rustls-cryptoprovider

Conversation

@Aaalibaba42
Copy link
Copy Markdown
Contributor

@Aaalibaba42 Aaalibaba42 commented Dec 9, 2025

What does this PR do?

rustls' install_default returns a Result<(), Arc<CryptoProvider>>, the Err case being the currently installed Crypto Provider. Currently, if for one reason or another, ensure_crypto_provider_initialized is called when a CryptoProvider is already installed, it will always panic.

This PR aims to panic if only necessary (ie, the installed crypto provider is not compatible with what's needed)

Motivation

AFAIK, no crashes related to this were reported in the real world, but this popped up in an antithesis report, and seems like a problem worth fixing.

Additional Notes

I also change the LazyLock<()> to a Once, LazyLock is a Once with a value and we hold no value into it.

How to test the change?

Future antithesis reports with similar scenarios should no longer contain this panic.

@Aaalibaba42 Aaalibaba42 requested a review from a team as a code owner December 9, 2025 16:10
@github-actions github-actions Bot added the common label Dec 9, 2025
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Dec 9, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-12-10 10:24:24

Comparing candidate commit 3444059 in PR branch jwiriath/fix-rustls-cryptoprovider with baseline commit 67d88eb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.670ms 9.907ms ± 0.054ms 9.907ms ± 0.026ms 9.934ms 9.978ms 10.035ms 10.152ms 2.47% -0.500 5.503 0.55% 0.004ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.900ms; 9.915ms] or [-0.076%; +0.076%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 61.970ms 62.537ms ± 2.099ms 62.259ms ± 0.095ms 62.363ms 62.672ms 73.320ms 82.102ms 31.87% 8.396 71.352 3.35% 0.148ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [62.246ms; 62.828ms] or [-0.465%; +0.465%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 536.467µs 537.101µs ± 0.481µs 537.005µs ± 0.198µs 537.232µs 537.872µs 538.152µs 541.541µs 0.84% 4.404 35.165 0.09% 0.034µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [537.035µs; 537.168µs] or [-0.012%; +0.012%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.183ms 14.240ms ± 0.035ms 14.239ms ± 0.019ms 14.254ms 14.289ms 14.356ms 14.442ms 1.43% 1.766 6.425 0.24% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.235ms; 14.245ms] or [-0.034%; +0.034%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.323µs 2.395µs ± 0.017µs 2.398µs ± 0.004µs 2.402µs 2.415µs 2.433µs 2.436µs 1.57% -1.646 4.487 0.72% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.393µs; 2.398µs] or [-0.100%; +0.100%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.591ms 10.622ms ± 0.014ms 10.621ms ± 0.008ms 10.630ms 10.648ms 10.663ms 10.683ms 0.58% 0.832 1.873 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.620ms; 10.624ms] or [-0.018%; +0.018%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.980ms 3.986ms ± 0.007ms 3.985ms ± 0.002ms 3.986ms 3.991ms 3.992ms 4.071ms 2.18% 10.731 134.400 0.17% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.985ms; 3.986ms] or [-0.023%; +0.023%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.150µs 534.071µs ± 0.680µs 534.037µs ± 0.326µs 534.297µs 534.781µs 536.869µs 539.820µs 1.08% 4.266 30.083 0.13% 0.048µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1852470.755op/s 1872413.519op/s ± 2372.153op/s 1872529.638op/s ± 1143.820op/s 1873772.799op/s 1875087.061op/s 1875287.721op/s 1875645.374op/s 0.17% -4.213 29.526 0.13% 167.737op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 381.237µs 381.982µs ± 0.328µs 381.936µs ± 0.213µs 382.188µs 382.548µs 382.853µs 383.132µs 0.31% 0.642 0.660 0.09% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2610064.135op/s 2617928.486op/s ± 2243.754op/s 2618242.089op/s ± 1457.164op/s 2619448.861op/s 2621130.608op/s 2622290.208op/s 2623037.569op/s 0.18% -0.637 0.648 0.09% 158.657op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 188.739µs 189.211µs ± 0.193µs 189.189µs ± 0.115µs 189.322µs 189.523µs 189.744µs 189.815µs 0.33% 0.316 0.239 0.10% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5268299.339op/s 5285106.888op/s ± 5379.581op/s 5285707.001op/s ± 3216.581op/s 5288398.691op/s 5293756.329op/s 5295585.169op/s 5298310.793op/s 0.24% -0.309 0.231 0.10% 380.394op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.842µs 36.933µs ± 0.044µs 36.930µs ± 0.024µs 36.954µs 37.005µs 37.057µs 37.151µs 0.60% 1.249 3.886 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26917121.089op/s 27075870.433op/s ± 32117.417op/s 27078401.103op/s ± 17941.822op/s 27096109.546op/s 27120295.872op/s 27131502.069op/s 27143144.581op/s 0.24% -1.234 3.813 0.12% 2271.044op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.902µs 45.154µs ± 0.163µs 45.144µs ± 0.123µs 45.276µs 45.344µs 45.413µs 46.432µs 2.85% 2.370 17.105 0.36% 0.011µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21537082.429op/s 22146722.603op/s ± 79090.963op/s 22151100.781op/s ± 60311.889op/s 22207059.736op/s 22249919.803op/s 22262731.488op/s 22270519.005op/s 0.54% -2.229 15.709 0.36% 5592.576op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [533.977µs; 534.165µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1872084.761op/s; 1872742.276op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.936µs; 382.027µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2617617.523op/s; 2618239.448op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.184µs; 189.238µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5284361.330op/s; 5285852.446op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.927µs; 36.939µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27071419.268op/s; 27080321.598op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.131µs; 45.177µs] or [-0.050%; +0.050%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22135761.356op/s; 22157683.850op/s] or [-0.049%; +0.049%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.015µs 5.099µs ± 0.049µs 5.123µs ± 0.045µs 5.134µs 5.169µs 5.175µs 5.178µs 1.08% -0.133 -1.466 0.95% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.092µs; 5.106µs] or [-0.132%; +0.132%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.171µs 3.192µs ± 1.432µs 3.021µs ± 0.023µs 3.039µs 3.367µs 13.849µs 15.210µs 403.42% 7.476 56.636 44.76% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.994µs; 3.391µs] or [-6.219%; +6.219%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.121µs 162.047µs ± 0.288µs 161.995µs ± 0.163µs 162.179µs 162.609µs 162.877µs 162.950µs 0.59% 0.693 0.952 0.18% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [162.007µs; 162.087µs] or [-0.025%; +0.025%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 187.852ns 190.898ns ± 2.408ns 190.543ns ± 1.570ns 192.067ns 195.599ns 197.930ns 200.373ns 5.16% 1.142 1.119 1.26% 0.170ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.564ns; 191.232ns] or [-0.175%; +0.175%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 246.358ns 255.489ns ± 12.264ns 250.875ns ± 2.539ns 254.722ns 286.714ns 293.000ns 294.712ns 17.47% 2.033 2.855 4.79% 0.867ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.789ns; 257.189ns] or [-0.665%; +0.665%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.835µs 35.284µs ± 0.745µs 34.948µs ± 0.045µs 35.004µs 36.853µs 37.000µs 38.191µs 9.28% 1.767 1.466 2.11% 0.053µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [35.181µs; 35.387µs] or [-0.293%; +0.293%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.917µs 3.919µs 0.19% -0.999 7.339 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255186208.089op/s 255670944.155op/s ± 174649.105op/s 255677500.380op/s ± 110452.309op/s 255779924.832op/s 255928307.245op/s 255981031.871op/s 256788939.175op/s 0.43% 1.016 7.449 0.07% 12349.557op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.239µs 80.884µs ± 0.799µs 80.810µs ± 0.562µs 81.432µs 82.325µs 82.616µs 83.409µs 3.22% 0.398 -0.265 0.99% 0.056µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11989045.493op/s 12364651.081op/s ± 121697.654op/s 12374773.417op/s ± 85410.251op/s 12454604.442op/s 12539727.876op/s 12585161.442op/s 12620082.887op/s 1.98% -0.352 -0.322 0.98% 8605.324op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 74.481µs 75.044µs ± 0.191µs 75.047µs ± 0.115µs 75.142µs 75.378µs 75.547µs 75.653µs 0.81% 0.214 0.742 0.25% 0.014µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13218272.545op/s 13325633.263op/s ± 33960.441op/s 13324939.949op/s ± 20386.387op/s 13346799.326op/s 13380561.863op/s 13407798.300op/s 13426331.722op/s 0.76% -0.193 0.734 0.25% 2401.366op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.917µs 3.920µs 3.921µs 0.22% -1.023 8.522 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255059774.460op/s 255611039.871op/s ± 190980.458op/s 255611826.700op/s ± 96970.699op/s 255708508.703op/s 255898642.638op/s 255996065.082op/s 256864469.386op/s 0.49% 1.044 8.657 0.07% 13504.358op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.528µs 72.189µs ± 0.223µs 72.189µs ± 0.135µs 72.317µs 72.548µs 72.814µs 72.871µs 0.94% 0.153 0.761 0.31% 0.016µs 1 200
credit_card/is_card_number/378282246310005 throughput 13722922.157op/s 13852657.763op/s ± 42728.033op/s 13852500.477op/s ± 25960.595op/s 13878797.036op/s 13926083.345op/s 13951413.867op/s 13980620.647op/s 0.92% -0.128 0.750 0.31% 3021.328op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.123µs 52.190µs ± 0.032µs 52.186µs ± 0.022µs 52.213µs 52.246µs 52.269µs 52.287µs 0.19% 0.357 -0.223 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19125151.806op/s 19160837.651op/s ± 11574.708op/s 19162113.627op/s ± 8037.489op/s 19169415.198op/s 19178669.197op/s 19182532.904op/s 19185246.545op/s 0.12% -0.354 -0.227 0.06% 818.455op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.695µs 5.854µs ± 0.072µs 5.852µs ± 0.051µs 5.904µs 5.972µs 6.008µs 6.027µs 3.00% 0.065 -0.557 1.23% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165911532.823op/s 170838640.088op/s ± 2105755.647op/s 170892400.494op/s ± 1483633.613op/s 172258608.004op/s 174474008.238op/s 175546457.064op/s 175587877.569op/s 2.75% -0.011 -0.557 1.23% 148899.410op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.891µs 3.913µs ± 0.003µs 3.912µs ± 0.002µs 3.915µs 3.919µs 3.920µs 3.921µs 0.23% -0.768 5.888 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255014851.598op/s 255589853.895op/s ± 225357.712op/s 255604263.427op/s ± 142269.658op/s 255730975.415op/s 255912462.365op/s 255973165.607op/s 256972812.035op/s 0.54% 0.787 6.007 0.09% 15935.197op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.166µs 64.364µs ± 0.125µs 64.333µs ± 0.065µs 64.409µs 64.636µs 64.725µs 64.747µs 0.64% 1.227 0.986 0.19% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15444715.739op/s 15536694.412op/s ± 30175.697op/s 15544116.569op/s ± 15830.571op/s 15558297.540op/s 15570435.947op/s 15575535.295op/s 15584661.576op/s 0.26% -1.218 0.964 0.19% 2133.744op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.401µs 57.603µs ± 0.160µs 57.565µs ± 0.068µs 57.652µs 57.865µs 58.225µs 58.554µs 1.72% 2.534 9.897 0.28% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17078364.862op/s 17360469.365op/s ± 48013.652op/s 17371692.827op/s ± 20509.140op/s 17389166.117op/s 17408662.029op/s 17416754.519op/s 17421405.681op/s 0.29% -2.489 9.564 0.28% 3395.078op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.891µs 3.911µs ± 0.002µs 3.911µs ± 0.001µs 3.912µs 3.914µs 3.917µs 3.918µs 0.18% -2.010 17.409 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255255641.818op/s 255710474.025op/s ± 162855.371op/s 255719231.085op/s ± 96079.462op/s 255809125.997op/s 255917174.239op/s 255969476.635op/s 256986351.794op/s 0.50% 2.040 17.668 0.06% 11515.614op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.573µs 54.829µs ± 0.174µs 54.789µs ± 0.091µs 54.896µs 55.168µs 55.377µs 55.749µs 1.75% 1.749 4.468 0.32% 0.012µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17937576.645op/s 18238762.268op/s ± 57515.770op/s 18251746.945op/s ± 30227.030op/s 18278091.454op/s 18302721.708op/s 18315481.913op/s 18324231.964op/s 0.40% -1.717 4.282 0.31% 4066.979op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.129µs 52.213µs ± 0.041µs 52.214µs ± 0.027µs 52.239µs 52.272µs 52.298µs 52.470µs 0.49% 1.155 6.222 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19058507.733op/s 19152491.431op/s ± 15183.674op/s 19152134.992op/s ± 9752.015op/s 19162594.616op/s 19176551.967op/s 19182627.637op/s 19183356.520op/s 0.16% -1.138 6.112 0.08% 1073.648op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.694µs 5.865µs ± 0.072µs 5.864µs ± 0.047µs 5.920µs 5.980µs 6.002µs 6.023µs 2.71% -0.190 -0.453 1.22% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 166029298.637op/s 170519693.656op/s ± 2099669.655op/s 170521686.939op/s ± 1380442.450op/s 171732826.923op/s 174451609.381op/s 175320647.310op/s 175611144.756op/s 2.98% 0.246 -0.415 1.23% 148469.065op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255646739.469op/s; 255695148.841op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [80.773µs; 80.994µs] or [-0.137%; +0.137%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12347784.956op/s; 12381517.205op/s] or [-0.136%; +0.136%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [75.017µs; 75.070µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13320926.672op/s; 13330339.853op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255584571.817op/s; 255637507.926op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.158µs; 72.220µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/378282246310005 throughput [13846736.069op/s; 13858579.458op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.185µs; 52.194µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19159233.508op/s; 19162441.794op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.844µs; 5.864µs] or [-0.171%; +0.171%] None None None
credit_card/is_card_number/x371413321323331 throughput [170546802.608op/s; 171130477.569op/s] or [-0.171%; +0.171%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ throughput [255558621.483op/s; 255621086.306op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.347µs; 64.381µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15532512.351op/s; 15540876.473op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.580µs; 57.625µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17353815.134op/s; 17367123.595op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.910µs; 3.911µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255687903.837op/s; 255733044.213op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.805µs; 54.853µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18230791.135op/s; 18246733.400op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.207µs; 52.218µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19150387.119op/s; 19154595.742op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.855µs; 5.875µs] or [-0.170%; +0.170%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [170228699.635op/s; 170810687.676op/s] or [-0.171%; +0.171%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 206.091µs 207.361µs ± 0.654µs 207.575µs ± 0.363µs 207.819µs 208.191µs 208.596µs 209.699µs 1.02% -0.206 -0.315 0.31% 0.046µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4768732.580op/s 4822548.306op/s ± 15211.690op/s 4817544.299op/s ± 8421.627op/s 4834464.045op/s 4847844.663op/s 4851325.633op/s 4852233.745op/s 0.72% 0.222 -0.345 0.31% 1075.629op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.591µs 18.703µs ± 0.087µs 18.678µs ± 0.031µs 18.716µs 18.882µs 19.085µs 19.097µs 2.25% 2.307 5.989 0.47% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52363850.660op/s 53468567.800op/s ± 247061.987op/s 53540283.177op/s ± 88584.609op/s 53611081.171op/s 53686637.518op/s 53742812.748op/s 53790743.069op/s 0.47% -2.270 5.781 0.46% 17469.921op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.769µs 10.842µs ± 0.032µs 10.837µs ± 0.017µs 10.860µs 10.892µs 10.931µs 10.973µs 1.25% 0.756 1.660 0.29% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 91136521.117op/s 92234854.341op/s ± 271217.321op/s 92272235.496op/s ± 145711.359op/s 92396051.803op/s 92626672.961op/s 92821832.021op/s 92855775.842op/s 0.63% -0.729 1.597 0.29% 19177.961op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [207.271µs; 207.452µs] or [-0.044%; +0.044%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4820440.112op/s; 4824656.499op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.691µs; 18.715µs] or [-0.065%; +0.065%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53434327.385op/s; 53502808.215op/s] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.838µs; 10.846µs] or [-0.041%; +0.041%] None None None
normalization/normalize_name/normalize_name/good throughput [92197266.228op/s; 92272442.453op/s] or [-0.041%; +0.041%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.548µs 26.010µs ± 9.526µs 18.718µs ± 0.682µs 34.113µs 42.764µs 44.136µs 71.873µs 283.99% 1.008 1.155 36.53% 0.674µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.690µs; 27.331µs] or [-5.076%; +5.076%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 145.217µs 147.049µs ± 1.581µs 146.866µs ± 0.589µs 147.492µs 148.392µs 151.967µs 162.386µs 10.57% 5.781 48.130 1.07% 0.112µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.830µs; 147.268µs] or [-0.149%; +0.149%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3444059 1765361298 jwiriath/fix-rustls-cryptoprovider
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 85.737µs 86.157µs ± 0.163µs 86.142µs ± 0.062µs 86.206µs 86.305µs 86.777µs 87.703µs 1.81% 4.767 41.219 0.19% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.134µs; 86.179µs] or [-0.026%; +0.026%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.14%. Comparing base (897c25f) to head (3444059).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   71.12%   71.14%   +0.01%     
==========================================
  Files         403      403              
  Lines       64084    64134      +50     
==========================================
+ Hits        45581    45626      +45     
- Misses      18503    18508       +5
Components Coverage Δ
libdd-crashtracker 58.79% <ø> (+0.03%) ⬆️
libdd-crashtracker-ffi 16.74% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 85.81% <ø> (ø)
libdd-data-pipeline-ffi 76.59% <ø> (ø)
libdd-common 81.13% <100.00%> (-0.02%) ⬇️
libdd-common-ffi 74.96% <ø> (ø)
libdd-telemetry 59.98% <ø> (-0.04%) ⬇️
libdd-telemetry-ffi 21.24% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.61% <ø> (-0.11%) ⬇️
libdd-profiling 80.42% <ø> (+0.09%) ⬆️
libdd-profiling-ffi 63.41% <ø> (+1.27%) ⬆️
datadog-sidecar 35.88% <ø> (ø)
datdog-sidecar-ffi 10.82% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 98.24% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 59.65% <ø> (ø)
libdd-trace-utils 89.88% <ø> (ø)
datadog-tracer-flare 63.49% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Aaalibaba42 Aaalibaba42 marked this pull request as draft December 9, 2025 17:02
@Aaalibaba42 Aaalibaba42 force-pushed the jwiriath/fix-rustls-cryptoprovider branch from ca60487 to ff90dbc Compare December 9, 2025 17:25
@Aaalibaba42 Aaalibaba42 marked this pull request as ready for review December 9, 2025 17:26
ekump
ekump reviewed Dec 9, 2025
View reviewed changes
Comment thread libdd-common/src/connector/mod.rs Outdated
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Dec 9, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 86.30 MB 86.28 MB --.01% (-14.15 KB) 💪
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.44 MB 7.44 MB -0% (-16 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 58.37 MB 58.36 MB --.02% (-12.21 KB) 💪
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.45 MB 8.45 MB -0% (-816 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.60 MB 9.54 MB --.66% (-65.22 KB) 💪
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.09 MB 100.08 MB --.01% (-15.61 KB) 💪
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 19.71 MB 19.71 MB -0% (-512 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 69.82 KB 69.82 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 140.12 MB 140.12 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 744.59 MB 744.57 MB -0% (-16.00 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.37 MB 6.37 MB +0% (+512 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 69.82 KB 69.82 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 19.74 MB 19.74 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 38.78 MB 38.78 MB -0% (-516 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 16.82 MB 16.82 MB -0% (-512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 70.90 KB 70.90 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 142.73 MB 142.74 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 733.09 MB 733.08 MB -0% (-15.47 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.89 MB 4.89 MB +0% (+512 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 70.90 KB 70.90 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 20.98 MB 20.98 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 36.54 MB 36.54 MB -0% (-700 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.64 MB 74.63 MB --.01% (-12.18 KB) 💪
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.86 MB 8.86 MB -0% (-16 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 59.73 MB 59.71 MB --.01% (-11.92 KB) 💪
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 9.49 MB 9.49 MB -0% (-816 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 94.30 MB 94.29 MB --.01% (-14.50 KB) 💪
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.30 MB 10.30 MB -0% (-872 B) 👌

@Aaalibaba42
Copy link
Copy Markdown
Contributor Author

Aaalibaba42 commented Dec 10, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Dec 10, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-10 10:08:58 UTC ℹ️ Start processing command /merge

2025-12-10 10:09:05 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-10 10:35:30 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 34m (p90).

2025-12-10 11:00:05 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue Bot merged commit 2f641ea into main Dec 10, 2025
38 checks passed
@dd-mergequeue dd-mergequeue Bot deleted the jwiriath/fix-rustls-cryptoprovider branch December 10, 2025 11:00
This was referenced Jan 14, 2026
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 15, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@github-actions github-actions Bot mentioned this pull request Jan 22, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekump ekump ekump approved these changes

Assignees

No one assigned

Labels

common mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaalibaba42 @codecov-commenter @ekump