chore(profiling): remove outdated info#1462
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom Jan 23, 2026
Merged
chore(profiling): remove outdated info#1462gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1462 +/- ##
==========================================
- Coverage 71.11% 71.09% -0.02%
==========================================
Files 417 417
Lines 67037 67037
==========================================
- Hits 47671 47662 -9
- Misses 19366 19375 +9
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
merged commit fe7ff46
into
main
50 of 51 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
kowalski/chore-profiling-remove-outdated-info
branch
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://datadoghq.atlassian.net/browse/PROF-13532
The PR:
ddog_prof_Exporter_Request_buildwhich is a function that doesn't exist anymore after feat!(profiling): Simpler API for profile exporter #1423.RequestBuildResultwhich doesn't exist anymore as far as I can tell after this function has been removed (although I'm not sure about this change).Motivation
Looking at the code and scratching my head real hard about where that
ddog_prof_Exporter_Request_buildfunction was defined!How to test the change?
Should be a no-op I think.