Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
swap-storage: true
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
- name: Install Rust
run: rustup install nightly-2024-12-16 && rustup default nightly-2024-12-16
run: rustup install nightly-2026-02-08 && rustup default nightly-2026-02-08
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@2c41309d51ede152b6f2ee6bf3b71e6dc9a8b7df # 2.49.27
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/fuzz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
run: |
set -e
rustup set profile minimal
rustup toolchain install nightly-2024-12-16
rustup default nightly-2024-12-16
rustup toolchain install nightly-2026-02-08
rustup default nightly-2026-02-08
- uses: taiki-e/install-action@2c41309d51ede152b6f2ee6bf3b71e6dc9a8b7df # 2.49.27
with:
tool: cargo-bolero
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
steps:
- name: Checkout sources
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # 4.2.2
- name: Install nightly-2024-12-16 toolchain and rustfmt
run: rustup install nightly-2024-12-16 && rustup default nightly-2024-12-16 && rustup component add rustfmt
- name: Install nightly-2026-02-08 toolchain and rustfmt
run: rustup install nightly-2026-02-08 && rustup default nightly-2026-02-08 && rustup component add rustfmt
- name: Cache [rust]
uses: Swatinem/rust-cache@f13886b937689c021905a6b90929199931d60db1 # 2.8.1
with:
Expand All @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
rust_version: ["1.84.1", "stable", "nightly-2024-12-16"]
rust_version: ["1.84.1", "stable", "nightly-2026-02-08"]
platform: [windows-latest, ubuntu-latest]
steps:
- name: Checkout sources
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/miri.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
run: |
set -e
rustup set profile minimal
rustup toolchain install nightly-2024-12-16 --component miri
rustup default nightly-2024-12-16
rustup toolchain install nightly-2026-02-08 --component miri
rustup default nightly-2026-02-08
- uses: taiki-e/install-action@2c41309d51ede152b6f2ee6bf3b71e6dc9a8b7df # 2.49.27
with:
tool: nextest@0.9.96
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/pr-title-semver-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ jobs:
persist-credentials: false

- name: Install Rust ${{ env.RUST_VERSION }}
run: rustup install ${{ env.RUST_VERSION }} && rustup default ${{ env.RUST_VERSION }} && rustup install nightly --profile minimal
run: |
rustup install ${{ env.RUST_VERSION }} && rustup default ${{ env.RUST_VERSION }}
rustup toolchain install nightly-2026-02-08 --profile minimal
# Link the dated nightly as 'nightly' for tools (like cargo-public-api) that expect it
ln -sf ~/.rustup/toolchains/nightly-2026-02-08-x86_64-unknown-linux-gnu ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu

- name: Cache [rust]
uses: Swatinem/rust-cache@f13886b937689c021905a6b90929199931d60db1 # 2.8.1
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/release-proposal-dispatch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ jobs:
with:
cache-targets: true
- uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2026-02-08
- name: Link nightly toolchain for cargo-public-api
run: ln -sf ~/.rustup/toolchains/nightly-2026-02-08-x86_64-unknown-linux-gnu ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: 1.92.0
Expand Down
2 changes: 1 addition & 1 deletion .gitlab/fuzz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ fuzz:
timeout: 1h
script:
- VAULT_VERSION=1.15.4 && curl -fsSL "https://releases.hashicorp.com/vault/${VAULT_VERSION}/vault_${VAULT_VERSION}_linux_amd64.zip" -o vault.zip && unzip vault.zip && mv vault /usr/local/bin/vault && rm vault.zip && chmod +x /usr/local/bin/vault
- rustup default nightly
- rustup default nightly-2026-02-08
- cargo install cargo-fuzz
- pip3 install requests toml
- python3 fuzz/fuzz_infra.py
Expand Down
5 changes: 1 addition & 4 deletions bin_tests/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ fn get_base_target_dir() -> &'static PathBuf {
// Otherwise, find the target directory by walking up from the current binary.
let test_bin_location = PathBuf::from(env::args().next().unwrap());
let mut location_components = test_bin_location.components().rev().peekable();
loop {
let Some(c) = location_components.peek() else {
break;
};
while let Some(c) = location_components.peek() {
if c.as_os_str() == "target" {
break;
}
Expand Down
4 changes: 3 additions & 1 deletion bin_tests/tests/crashtracker_bin_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ use std::process;
use std::{fs, path::PathBuf};

use anyhow::Context;
#[cfg(all(target_os = "linux", not(target_env = "musl")))]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these CFGs for, in relation to updating nightly? New warnings or..?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only used in tests that have the same gate to not run on our alpine builds at the moment and I was getting unused import warnings.

use bin_tests::test_runner::run_crash_no_op;
use bin_tests::{
artifacts::{self, StandardArtifacts},
build_artifacts,
test_runner::{run_crash_no_op, run_crash_test_with_artifacts, CrashTestConfig, ValidatorFn},
test_runner::{run_crash_test_with_artifacts, CrashTestConfig, ValidatorFn},
test_types::{CrashType, TestMode},
validation::PayloadValidator,
ArtifactsBuild, BuildProfile,
Expand Down
1 change: 1 addition & 0 deletions libdd-crashtracker/src/collector/api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ pub fn default_signals() -> Vec<libc::c_int> {
Vec::from(DEFAULT_SYMBOLS)
}

#[cfg(target_os = "linux")]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only called by tests that have the same cfg targets. It should resolve dead code warnings on other envs.

pub(super) fn mark_preload_logger_collector() {
// This function is specific only for LD_PRELOAD testing
// Best effort; this symbol exists only when the preload logger preload is present.
Expand Down
3 changes: 2 additions & 1 deletion libdd-crashtracker/src/receiver/receive_report.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ use libdd_telemetry::data::LogLevel;
use serde::{Deserialize, Serialize};
use std::sync::Arc;
use std::time::{Duration, Instant};
use std::{fs, path::PathBuf};
use tokio::io::AsyncBufReadExt;

#[derive(Debug)]
Expand Down Expand Up @@ -524,6 +523,8 @@ pub(crate) async fn receive_report_from_stream(

#[cfg(target_os = "linux")]
fn enrich_thread_name(builder: &mut CrashInfoBuilder) -> anyhow::Result<()> {
use std::{fs, path::PathBuf};
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved the import since it's only used for linux with this function. It should resolve unused import warnings in other envs.


if builder.error.thread_name.is_some() {
return Ok(());
}
Expand Down
7 changes: 1 addition & 6 deletions libdd-library-config/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,13 @@ impl<'a> MatchMaps<'a> {
fn args(&self, process_info: &'a ProcessInfo) -> &HashMap<&str, &str> {
self.args_map.get_or_init(|| {
let mut map = HashMap::new();
let mut args = process_info.args.iter().peekable();
loop {
let Some(arg) = args.next() else {
break;
};
for arg in &process_info.args {
let Ok(arg) = std::str::from_utf8(arg.deref()) else {
continue;
};
// Split args between key and value on '='
if let Some((k, v)) = arg.split_once('=') {
map.insert(k, v);
continue;
}
}
map
Expand Down
5 changes: 1 addition & 4 deletions tools/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@ pub mod headers {
let mut items = Vec::new();
let mut start = 0;

loop {
let Some(head) = ITEM_DEFINITION_HEAD.captures_at(header, start) else {
break;
};
while let Some(head) = ITEM_DEFINITION_HEAD.captures_at(header, start) {
start = head.get(0).unwrap().start();
let end: usize;
if let Some(capture) = head.get(2) {
Expand Down
Loading