feat(telemetry): add session id support to trace export#1822
Conversation
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 299a8f4 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
==========================================
- Coverage 71.68% 71.68% -0.01%
==========================================
Files 434 434
Lines 70216 70336 +120
==========================================
+ Hits 50335 50421 +86
- Misses 19881 19915 +34
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-03-30 18:50:09 Comparing candidate commit d01347e in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 0 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_serialize_compressed_pprof_timestamped_x1000 | execution_time | 910.711µs | 914.703µs ± 2.443µs | 914.166µs ± 0.851µs | 915.187µs | 918.657µs | 923.860µs | 932.376µs | 1.99% | 3.394 | 17.588 | 0.27% | 0.173µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_serialize_compressed_pprof_timestamped_x1000 | execution_time | [914.364µs; 915.042µs] or [-0.037%; +0.037%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | 4.178ms | 4.182ms ± 0.002ms | 4.182ms ± 0.001ms | 4.183ms | 4.185ms | 4.190ms | 4.194ms | 0.28% | 1.723 | 7.442 | 0.05% | 0.000ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_frames_x1000 | execution_time | [4.182ms; 4.183ms] or [-0.007%; +0.007%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 5.365µs | 5.430µs ± 0.035µs | 5.424µs ± 0.018µs | 5.445µs | 5.483µs | 5.553µs | 5.616µs | 3.54% | 1.625 | 5.339 | 0.64% | 0.002µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [5.425µs; 5.435µs] or [-0.088%; +0.088%] | None | None | None |
Group 4
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 14.865µs | 15.214µs ± 0.242µs | 15.146µs ± 0.124µs | 15.361µs | 15.598µs | 15.709µs | 17.063µs | 12.66% | 2.564 | 15.375 | 1.59% | 0.017µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [15.180µs; 15.247µs] or [-0.221%; +0.221%] | None | None | None |
Group 5
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | 162.073µs | 163.548µs ± 0.425µs | 163.476µs ± 0.193µs | 163.767µs | 164.330µs | 164.890µs | 165.501µs | 1.24% | 0.858 | 2.988 | 0.26% | 0.030µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching string interning on wordpress profile | execution_time | [163.490µs; 163.607µs] or [-0.036%; +0.036%] | None | None | None |
Group 6
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | 50.660ms | 50.950ms ± 1.298ms | 50.793ms ± 0.042ms | 50.830ms | 50.947ms | 57.955ms | 65.198ms | 28.36% | 9.015 | 85.227 | 2.54% | 0.092ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching deserializing traces from msgpack to their internal representation | execution_time | [50.770ms; 51.130ms] or [-0.353%; +0.353%] | None | None | None |
Group 7
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | 243.229ns | 255.828ns ± 13.014ns | 250.123ns ± 4.963ns | 264.611ns | 283.845ns | 288.092ns | 289.124ns | 15.59% | 1.125 | -0.078 | 5.07% | 0.920ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_trace/test_trace | execution_time | [254.024ns; 257.632ns] or [-0.705%; +0.705%] | None | None | None |
Group 8
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | 5.013µs | 5.118µs ± 0.054µs | 5.125µs ± 0.052µs | 5.155µs | 5.197µs | 5.200µs | 5.202µs | 1.50% | -0.143 | -1.278 | 1.05% | 0.004µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| ip_address/quantize_peer_ip_address_benchmark | execution_time | [5.110µs; 5.125µs] or [-0.145%; +0.145%] | None | None | None |
Group 9
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | 190.253ns | 192.821ns ± 1.977ns | 192.703ns ± 1.295ns | 193.671ns | 196.570ns | 198.628ns | 199.208ns | 3.38% | 1.010 | 0.771 | 1.02% | 0.140ns | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| single_flag_killswitch/rules-based | execution_time | [192.547ns; 193.095ns] or [-0.142%; +0.142%] | None | None | None |
Group 10
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | 13.771ms | 13.820ms ± 0.025ms | 13.818ms ± 0.012ms | 13.830ms | 13.856ms | 13.893ms | 13.998ms | 1.30% | 2.314 | 13.034 | 0.18% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| benching serializing traces from their internal representation to msgpack | execution_time | [13.817ms; 13.824ms] or [-0.025%; +0.025%] | None | None | None |
Group 11
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | 720.593µs | 721.722µs ± 0.420µs | 721.694µs ± 0.255µs | 721.989µs | 722.477µs | 722.700µs | 722.833µs | 0.16% | 0.155 | 0.076 | 0.06% | 0.030µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample2_frames_x1000 | execution_time | [721.663µs; 721.780µs] or [-0.008%; +0.008%] | None | None | None |
Group 12
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | 33.160µs | 33.985µs ± 1.467µs | 33.305µs ± 0.062µs | 33.412µs | 37.133µs | 37.196µs | 38.474µs | 15.52% | 1.717 | 1.024 | 4.31% | 0.104µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| redis/obfuscate_redis_string | execution_time | [33.782µs; 34.188µs] or [-0.598%; +0.598%] | None | None | None |
Group 13
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | 2.369µs | 2.421µs ± 0.019µs | 2.419µs ± 0.008µs | 2.427µs | 2.467µs | 2.473µs | 2.477µs | 2.41% | 0.708 | 1.804 | 0.78% | 0.001µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| tags/replace_trace_tags | execution_time | [2.418µs; 2.423µs] or [-0.108%; +0.108%] | None | None | None |
Group 14
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | 4.181ms | 4.187ms ± 0.009ms | 4.185ms ± 0.001ms | 4.187ms | 4.192ms | 4.213ms | 4.290ms | 2.50% | 8.731 | 94.461 | 0.21% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| profile_add_sample_timestamped_x1000 | execution_time | [4.185ms; 4.188ms] or [-0.029%; +0.029%] | None | None | None |
Group 15
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | 145.213µs | 147.497µs ± 1.822µs | 147.205µs ± 0.596µs | 147.837µs | 149.182µs | 154.233µs | 165.327µs | 12.31% | 5.865 | 49.030 | 1.23% | 0.129µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sdk_test_data/rules-based | execution_time | [147.244µs; 147.749µs] or [-0.171%; +0.171%] | None | None | None |
Group 16
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | 3.605ms | 3.634ms ± 0.017ms | 3.631ms ± 0.008ms | 3.640ms | 3.666ms | 3.686ms | 3.700ms | 1.88% | 1.231 | 2.035 | 0.46% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| receiver_entry_point/report/2598 | execution_time | [3.631ms; 3.636ms] or [-0.063%; +0.063%] | None | None | None |
Group 17
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 14.789ms | 14.850ms ± 0.035ms | 14.842ms ± 0.021ms | 14.871ms | 14.919ms | 14.941ms | 14.965ms | 0.83% | 0.786 | 0.140 | 0.23% | 0.002ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [14.846ms; 14.855ms] or [-0.033%; +0.033%] | None | None | None |
Group 18
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | 185.750µs | 186.265µs ± 0.371µs | 186.219µs ± 0.226µs | 186.440µs | 186.872µs | 187.789µs | 188.119µs | 1.02% | 1.645 | 4.931 | 0.20% | 0.026µs | 1 | 200 |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | 5315772.855op/s | 5368717.432op/s ± 10649.330op/s | 5370022.761op/s ± 6528.005op/s | 5376645.980op/s | 5380895.318op/s | 5382766.653op/s | 5383575.009op/s | 0.25% | -1.620 | 4.790 | 0.20% | 753.021op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | execution_time | 17.814µs | 17.915µs ± 0.127µs | 17.898µs ± 0.024µs | 17.926µs | 18.025µs | 18.092µs | 19.505µs | 8.98% | 10.063 | 121.206 | 0.71% | 0.009µs | 1 | 200 |
| normalization/normalize_name/normalize_name/bad-name | throughput | 51268993.762op/s | 55820558.636op/s ± 370279.505op/s | 55872151.379op/s ± 74876.659op/s | 55923982.889op/s | 56075835.646op/s | 56126835.302op/s | 56136682.916op/s | 0.47% | -9.603 | 113.137 | 0.66% | 26182.715op/s | 1 | 200 |
| normalization/normalize_name/normalize_name/good | execution_time | 10.563µs | 10.622µs ± 0.039µs | 10.612µs ± 0.018µs | 10.634µs | 10.691µs | 10.775µs | 10.814µs | 1.91% | 2.080 | 6.197 | 0.37% | 0.003µs | 1 | 200 |
| normalization/normalize_name/normalize_name/good | throughput | 92471415.039op/s | 94149352.720op/s ± 345283.603op/s | 94234299.566op/s ± 157063.025op/s | 94334680.376op/s | 94564961.866op/s | 94636135.866op/s | 94673906.209op/s | 0.47% | -2.038 | 5.982 | 0.37% | 24415.238op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | execution_time | [186.214µs; 186.316µs] or [-0.028%; +0.028%] | None | None | None |
| normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... | throughput | [5367241.537op/s; 5370193.327op/s] or [-0.027%; +0.027%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | execution_time | [17.898µs; 17.933µs] or [-0.098%; +0.098%] | None | None | None |
| normalization/normalize_name/normalize_name/bad-name | throughput | [55769241.458op/s; 55871875.814op/s] or [-0.092%; +0.092%] | None | None | None |
| normalization/normalize_name/normalize_name/good | execution_time | [10.616µs; 10.627µs] or [-0.051%; +0.051%] | None | None | None |
| normalization/normalize_name/normalize_name/good | throughput | [94101499.733op/s; 94197205.706op/s] or [-0.051%; +0.051%] | None | None | None |
Group 19
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | 3.902µs | 3.917µs ± 0.004µs | 3.916µs ± 0.003µs | 3.919µs | 3.924µs | 3.927µs | 3.929µs | 0.34% | 0.559 | 0.723 | 0.10% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/ | throughput | 254515634.525op/s | 255323039.069op/s ± 257356.086op/s | 255375981.889op/s ± 165000.071op/s | 255515608.037op/s | 255607891.057op/s | 255714693.255op/s | 256268416.784op/s | 0.35% | -0.552 | 0.725 | 0.10% | 18197.823op/s | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | 79.172µs | 79.732µs ± 0.355µs | 79.685µs ± 0.253µs | 79.973µs | 80.337µs | 80.508µs | 81.430µs | 2.19% | 0.916 | 1.731 | 0.44% | 0.025µs | 1 | 200 |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | 12280461.172op/s | 12542195.567op/s ± 55631.348op/s | 12549417.065op/s ± 39784.968op/s | 12584338.797op/s | 12617511.279op/s | 12626465.746op/s | 12630653.333op/s | 0.65% | -0.879 | 1.558 | 0.44% | 3933.730op/s | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | execution_time | 72.378µs | 73.037µs ± 0.342µs | 73.008µs ± 0.228µs | 73.231µs | 73.658µs | 73.878µs | 74.318µs | 1.80% | 0.638 | 0.428 | 0.47% | 0.024µs | 1 | 200 |
| credit_card/is_card_number/ 378282246310005 | throughput | 13455608.474op/s | 13692074.949op/s ± 63991.986op/s | 13697175.716op/s ± 42571.811op/s | 13743184.868op/s | 13777526.845op/s | 13809634.439op/s | 13816330.742op/s | 0.87% | -0.610 | 0.362 | 0.47% | 4524.917op/s | 1 | 200 |
| credit_card/is_card_number/37828224631 | execution_time | 3.895µs | 3.917µs ± 0.004µs | 3.916µs ± 0.003µs | 3.919µs | 3.924µs | 3.928µs | 3.937µs | 0.55% | 0.385 | 4.171 | 0.11% | 0.000µs | 1 | 200 |
| credit_card/is_card_number/37828224631 | throughput | 253997374.465op/s | 255323579.927op/s ± 286657.638op/s | 255389884.479op/s ± 173347.893op/s | 255502210.839op/s | 255640725.653op/s | 255731837.224op/s | 256758077.772op/s | 0.54% | -0.365 | 4.194 | 0.11% | 20269.756op/s | 1 | 200 |
| credit_card/is_card_number/378282246310005 | execution_time | 69.306µs | 69.690µs ± 0.266µs | 69.634µs ± 0.150µs | 69.829µs | 70.121µs | 70.737µs | 70.915µs | 1.84% | 1.523 | 3.699 | 0.38% | 0.019µs | 1 | 200 |
| credit_card/is_card_number/378282246310005 | throughput | 14101395.891op/s | 14349406.821op/s ± 54388.238op/s | 14360868.071op/s ± 30835.954op/s | 14388298.000op/s | 14413130.006op/s | 14426923.555op/s | 14428730.488op/s | 0.47% | -1.485 | 3.514 | 0.38% | 3845.829op/s | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | execution_time | 52.284µs | 52.374µs ± 0.052µs | 52.366µs ± 0.034µs | 52.405µs | 52.480µs | 52.505µs | 52.572µs | 0.39% | 0.796 | 0.431 | 0.10% | 0.004µs | 1 | 200 |
| credit_card/is_card_number/37828224631000521389798 | throughput | 19021430.614op/s | 19093469.837op/s ± 19004.113op/s | 19096426.711op/s ± 12578.446op/s | 19107783.452op/s | 19119303.633op/s | 19122142.630op/s | 19126336.826op/s | 0.16% | -0.791 | 0.417 | 0.10% | 1343.794op/s | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | execution_time | 5.710µs | 5.852µs ± 0.052µs | 5.850µs ± 0.036µs | 5.885µs | 5.940µs | 5.967µs | 5.972µs | 2.09% | 0.010 | -0.397 | 0.89% | 0.004µs | 1 | 200 |
| credit_card/is_card_number/x371413321323331 | throughput | 167436147.946op/s | 170898351.730op/s ± 1524727.638op/s | 170943336.472op/s ± 1050165.864op/s | 172009363.383op/s | 173344387.131op/s | 174173563.604op/s | 175137271.138op/s | 2.45% | 0.033 | -0.383 | 0.89% | 107814.525op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | execution_time | 3.894µs | 3.916µs ± 0.004µs | 3.915µs ± 0.002µs | 3.918µs | 3.922µs | 3.924µs | 3.930µs | 0.36% | -0.344 | 5.707 | 0.09% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ | throughput | 254483946.329op/s | 255365816.626op/s ± 239635.600op/s | 255411270.014op/s ± 145577.723op/s | 255537720.354op/s | 255642759.421op/s | 255755752.996op/s | 256788009.479op/s | 0.54% | 0.366 | 5.811 | 0.09% | 16944.796op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | 64.044µs | 64.414µs ± 0.164µs | 64.397µs ± 0.100µs | 64.508µs | 64.735µs | 64.862µs | 65.113µs | 1.11% | 0.805 | 1.292 | 0.25% | 0.012µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | 15357988.812op/s | 15524706.005op/s ± 39409.635op/s | 15528746.352op/s ± 24095.935op/s | 15550739.181op/s | 15577377.676op/s | 15600939.738op/s | 15614327.707op/s | 0.55% | -0.785 | 1.235 | 0.25% | 2786.682op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | 57.823µs | 58.081µs ± 0.190µs | 58.027µs ± 0.097µs | 58.156µs | 58.502µs | 58.613µs | 58.839µs | 1.40% | 1.455 | 2.014 | 0.33% | 0.013µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | 16995476.747op/s | 17217488.018op/s ± 56161.724op/s | 17233471.950op/s ± 28751.299op/s | 17257558.066op/s | 17277360.697op/s | 17284050.351op/s | 17294123.457op/s | 0.35% | -1.436 | 1.941 | 0.33% | 3971.234op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | 3.893µs | 3.916µs ± 0.004µs | 3.916µs ± 0.003µs | 3.919µs | 3.923µs | 3.927µs | 3.929µs | 0.34% | -0.243 | 4.921 | 0.10% | 0.000µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | 254498718.239op/s | 255342651.003op/s ± 267783.081op/s | 255373543.302op/s ± 173788.788op/s | 255527546.575op/s | 255656849.492op/s | 255733108.547op/s | 256878619.019op/s | 0.59% | 0.264 | 5.019 | 0.10% | 18935.123op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | 54.616µs | 54.887µs ± 0.222µs | 54.816µs ± 0.108µs | 55.003µs | 55.312µs | 55.634µs | 55.878µs | 1.94% | 1.520 | 2.611 | 0.40% | 0.016µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | 17896106.355op/s | 18219533.310op/s ± 73147.347op/s | 18242864.262op/s ± 36160.561op/s | 18271155.788op/s | 18292760.642op/s | 18305660.843op/s | 18309491.640op/s | 0.37% | -1.492 | 2.480 | 0.40% | 5172.299op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | 52.175µs | 52.289µs ± 0.066µs | 52.283µs ± 0.044µs | 52.328µs | 52.390µs | 52.468µs | 52.514µs | 0.44% | 0.629 | 0.321 | 0.13% | 0.005µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | 19042360.678op/s | 19124411.241op/s ± 23972.034op/s | 19126748.762op/s ± 16267.961op/s | 19142489.151op/s | 19157780.921op/s | 19162765.050op/s | 19166292.372op/s | 0.21% | -0.622 | 0.303 | 0.13% | 1695.079op/s | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | 5.711µs | 5.844µs ± 0.059µs | 5.842µs ± 0.038µs | 5.881µs | 5.939µs | 5.966µs | 5.977µs | 2.31% | 0.105 | -0.654 | 1.00% | 0.004µs | 1 | 200 |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | 167314123.701op/s | 171145147.758op/s ± 1717000.423op/s | 171175669.885op/s ± 1113462.938op/s | 172286805.417op/s | 173973845.773op/s | 174301011.512op/s | 175100844.357op/s | 2.29% | -0.064 | -0.661 | 1.00% | 121410.264op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| credit_card/is_card_number/ | execution_time | [3.916µs; 3.917µs] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/ | throughput | [255287371.990op/s; 255358706.147op/s] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | execution_time | [79.683µs; 79.782µs] or [-0.062%; +0.062%] | None | None | None |
| credit_card/is_card_number/ 3782-8224-6310-005 | throughput | [12534485.597op/s; 12549905.537op/s] or [-0.061%; +0.061%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | execution_time | [72.989µs; 73.084µs] or [-0.065%; +0.065%] | None | None | None |
| credit_card/is_card_number/ 378282246310005 | throughput | [13683206.275op/s; 13700943.623op/s] or [-0.065%; +0.065%] | None | None | None |
| credit_card/is_card_number/37828224631 | execution_time | [3.916µs; 3.917µs] or [-0.016%; +0.016%] | None | None | None |
| credit_card/is_card_number/37828224631 | throughput | [255283851.935op/s; 255363307.919op/s] or [-0.016%; +0.016%] | None | None | None |
| credit_card/is_card_number/378282246310005 | execution_time | [69.653µs; 69.727µs] or [-0.053%; +0.053%] | None | None | None |
| credit_card/is_card_number/378282246310005 | throughput | [14341869.134op/s; 14356944.508op/s] or [-0.053%; +0.053%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | execution_time | [52.367µs; 52.381µs] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/37828224631000521389798 | throughput | [19090836.050op/s; 19096103.624op/s] or [-0.014%; +0.014%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | execution_time | [5.845µs; 5.859µs] or [-0.124%; +0.124%] | None | None | None |
| credit_card/is_card_number/x371413321323331 | throughput | [170687039.144op/s; 171109664.317op/s] or [-0.124%; +0.124%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | execution_time | [3.915µs; 3.916µs] or [-0.013%; +0.013%] | None | None | None |
| credit_card/is_card_number_no_luhn/ | throughput | [255332605.436op/s; 255399027.815op/s] or [-0.013%; +0.013%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | execution_time | [64.391µs; 64.437µs] or [-0.035%; +0.035%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 | throughput | [15519244.208op/s; 15530167.801op/s] or [-0.035%; +0.035%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | execution_time | [58.055µs; 58.107µs] or [-0.045%; +0.045%] | None | None | None |
| credit_card/is_card_number_no_luhn/ 378282246310005 | throughput | [17209704.543op/s; 17225271.492op/s] or [-0.045%; +0.045%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | execution_time | [3.916µs; 3.917µs] or [-0.015%; +0.015%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631 | throughput | [255305538.843op/s; 255379763.162op/s] or [-0.015%; +0.015%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | execution_time | [54.856µs; 54.918µs] or [-0.056%; +0.056%] | None | None | None |
| credit_card/is_card_number_no_luhn/378282246310005 | throughput | [18209395.792op/s; 18229670.829op/s] or [-0.056%; +0.056%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | execution_time | [52.280µs; 52.298µs] or [-0.017%; +0.017%] | None | None | None |
| credit_card/is_card_number_no_luhn/37828224631000521389798 | throughput | [19121088.948op/s; 19127733.535op/s] or [-0.017%; +0.017%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | execution_time | [5.835µs; 5.852µs] or [-0.139%; +0.139%] | None | None | None |
| credit_card/is_card_number_no_luhn/x371413321323331 | throughput | [170907188.013op/s; 171383107.503op/s] or [-0.139%; +0.139%] | None | None | None |
Group 20
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | 495.783µs | 497.051µs ± 1.358µs | 496.698µs ± 0.413µs | 497.215µs | 500.081µs | 500.735µs | 507.253µs | 2.13% | 3.781 | 20.101 | 0.27% | 0.096µs | 1 | 200 |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | 1971402.183op/s | 2011881.272op/s ± 5441.174op/s | 2013297.382op/s ± 1675.095op/s | 2014860.097op/s | 2016199.977op/s | 2016665.601op/s | 2017013.283op/s | 0.18% | -3.718 | 19.437 | 0.27% | 384.749op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | 370.852µs | 371.850µs ± 0.484µs | 371.778µs ± 0.292µs | 372.089µs | 372.809µs | 373.170µs | 374.167µs | 0.64% | 1.115 | 2.302 | 0.13% | 0.034µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | 2672605.584op/s | 2689259.772op/s ± 3492.704op/s | 2689778.963op/s ± 2112.192op/s | 2691652.930op/s | 2693901.038op/s | 2694880.311op/s | 2696496.009op/s | 0.25% | -1.103 | 2.251 | 0.13% | 246.971op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | 167.926µs | 168.394µs ± 0.239µs | 168.367µs ± 0.145µs | 168.535µs | 168.791µs | 169.023µs | 169.280µs | 0.54% | 0.602 | 0.488 | 0.14% | 0.017µs | 1 | 200 |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | 5907379.705op/s | 5938477.530op/s ± 8409.981op/s | 5939397.975op/s ± 5135.519op/s | 5944203.147op/s | 5950730.375op/s | 5953310.152op/s | 5954986.671op/s | 0.26% | -0.593 | 0.465 | 0.14% | 594.675op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | 36.787µs | 37.020µs ± 0.115µs | 37.052µs ± 0.068µs | 37.105µs | 37.172µs | 37.209µs | 37.321µs | 0.73% | -0.440 | -0.695 | 0.31% | 0.008µs | 1 | 200 |
| normalization/normalize_service/normalize_service/[empty string] | throughput | 26794557.464op/s | 27012600.461op/s ± 83987.075op/s | 26989340.672op/s ± 49770.593op/s | 27073812.495op/s | 27168336.895op/s | 27180259.202op/s | 27183710.609op/s | 0.72% | 0.451 | -0.695 | 0.31% | 5938.783op/s | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | 46.272µs | 46.447µs ± 0.137µs | 46.417µs ± 0.046µs | 46.489µs | 46.627µs | 46.729µs | 47.928µs | 3.26% | 6.687 | 66.754 | 0.29% | 0.010µs | 1 | 200 |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | 20864654.464op/s | 21529949.388op/s ± 62369.584op/s | 21544032.052op/s ± 21268.211op/s | 21559983.377op/s | 21581277.206op/s | 21595606.402op/s | 21611528.454op/s | 0.31% | -6.478 | 63.625 | 0.29% | 4410.196op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | execution_time | [496.863µs; 497.239µs] or [-0.038%; +0.038%] | None | None | None |
| normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... | throughput | [2011127.177op/s; 2012635.366op/s] or [-0.037%; +0.037%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | execution_time | [371.783µs; 371.917µs] or [-0.018%; +0.018%] | None | None | None |
| normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて | throughput | [2688775.717op/s; 2689743.828op/s] or [-0.018%; +0.018%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | execution_time | [168.361µs; 168.427µs] or [-0.020%; +0.020%] | None | None | None |
| normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters | throughput | [5937311.988op/s; 5939643.073op/s] or [-0.020%; +0.020%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | execution_time | [37.004µs; 37.036µs] or [-0.043%; +0.043%] | None | None | None |
| normalization/normalize_service/normalize_service/[empty string] | throughput | [27000960.660op/s; 27024240.262op/s] or [-0.043%; +0.043%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | execution_time | [46.428µs; 46.466µs] or [-0.041%; +0.041%] | None | None | None |
| normalization/normalize_service/normalize_service/test_ASCII | throughput | [21521305.564op/s; 21538593.213op/s] or [-0.040%; +0.040%] | None | None | None |
Group 21
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | d01347e | 1774895527 | munir/add-session-id-to-trace-exporter |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | 289.584µs | 290.571µs ± 0.699µs | 290.468µs ± 0.149µs | 290.639µs | 291.245µs | 292.253µs | 298.732µs | 2.84% | 8.382 | 91.835 | 0.24% | 0.049µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| sql/obfuscate_sql_string | execution_time | [290.474µs; 290.668µs] or [-0.033%; +0.033%] | None | None | None |
Baseline
Omitted due to size.
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
0b9c1a7 to
d01347e
Compare
2974373 to
97c7629
Compare
Resolve conflicts by combining session instrumentation (session/root/parent headers and TelemetryInstrumentationSessions) with main's shared runtime and telemetry worker setup. FFI trace exporter uses GenericTraceExporter alias. Telemetry integration test uses SharedRuntime. Take telemetry expanded.rs from main. Made-with: Cursor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4624a37cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
What does this PR do?
Adds optional instrumentation session IDs for telemetry on the trace exporter path: FFI (
TelemetryClientConfig+ wiring), Rust (TelemetryInstrumentationSessions+ builder), C example, and a combined telemetry test for runtime id + session headers.Motivation
Allow trace-exporter telemetry to send
dd-session-id/ root / parent consistently with the rest of telemetry configuration.Additional notes
TelemetryConfigis unchanged.How to test
Build and run
examples/ffi/trace_exporter.cwith the updatedTelemetryClientConfigfields.