Skip to content

Revert "chore(ci): add final_status property on junit XML [APMSP-2610]" #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Apr 2, 2026
Merged

Revert "chore(ci): add final_status property on junit XML [APMSP-2610]" #1840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions .github/workflows/add_final_status.xsl
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,6 @@ jobs:
report_paths: "target/nextest/ci/junit.xml"
check_name: "[${{ matrix.platform }}:${{ matrix.rust_version }}] test report"
include_passed: true
# We're using not-that-ideal XSLT here as this change, because it must be done over 17+ repos.
# It's a workaround until this gets integrated into a better place, such as datadog-ci or the backend.
#
# * ticket: https://datadoghq.atlassian.net/browse/APMSP-2610
# * RFC: https://docs.google.com/document/d/1OaX_h09fCXWmK_1ADrwvilt8Yt5h4WjC7UUAdS3Y3uw/edit?pli=1&tab=t.0#heading=h.tfy5viz7rz2
- name: Add final_status property
if: success() || failure()
shell: bash
run: |
which xsltproc || sudo apt-get install -y xsltproc
echo "Fixing target/nextest/ci/junit.xml"
tmp_file="$(mktemp)"
xsltproc --output "$tmp_file" ".github/workflows/add_final_status.xsl" "target/nextest/ci/junit.xml"
mv "$tmp_file" "target/nextest/ci/junit.xml"

- name: Upload test results to Datadog
if: success() || failure()
shell: bash
Expand Down
Loading