Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 70.46% 70.48% +0.01%
==========================================
Files 205 205
Lines 27936 27934 -2
==========================================
+ Hits 19685 19688 +3
+ Misses 8251 8246 -5
|
2821933 to
182f14c
Compare
5e88a14 to
35f955c
Compare
We were running into symbol issues with older rustls versions, see briansmith/ring#1808. Note that the new rustls version requires nasm to be installed on windows, so we install it in CI. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
BenchmarksComparisonParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.
CandidateCandidate benchmark detailsGroup 1
WarningsBaselineBaseline benchmark detailsGroup 1
Warnings |
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
b430970 to
590c412
Compare
…But aws-lc-sys is actually preferable. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were running into symbol issues with older rustls versions, see briansmith/ring#1808.
Note that the new rustls version requires nasm to be installed on windows, so we install it in CI.