chore: enable data-pipeline feature in shipped artifacts#751
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 70.59% 70.55% -0.04%
==========================================
Files 296 296
Lines 43246 43246
==========================================
- Hits 30528 30512 -16
- Misses 12718 12734 +16
🚀 New features to boost your workflow:
|
ekump
approved these changes
Nov 21, 2024
Contributor
ekump
left a comment
There was a problem hiding this comment.
.NET build artifacts are not my area of expertise, but LGTM
danielsn
approved these changes
Nov 21, 2024
Contributor
I'm here for that ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With this change, we will start shipping the data-pipeline code in the shipped artifacts.
I also made some refactor to make it easier to make such changes in future so we don't make mistake like
cbindgen,datadog-profiling-ffi/ddtelemetry-ffiwas included multiple times in past atlibdatadog/build-profiling-ffi.sh
Line 141 in c6ad4ff
Motivation
data-pipeline integration in .NET SDK requires data-pipeline stuff as per DataDog/dd-trace-dotnet#6314, hence we need to start shipping the code so integrations can use it
How to test the change?
on mac
on windows