Skip to content

[SVLS-3545] Add Serverless metric origins to dogstatsd package#876

Closed
DylanLovesCoffee wants to merge 43 commits intomainfrom
dylan/metric-origins
Closed

[SVLS-3545] Add Serverless metric origins to dogstatsd package#876
DylanLovesCoffee wants to merge 43 commits intomainfrom
dylan/metric-origins

Conversation

@DylanLovesCoffee
Copy link
Copy Markdown

@DylanLovesCoffee DylanLovesCoffee commented Feb 12, 2025

What does this PR do?

Adds metric origins for Serverless. This will affect the Lambda Extension and Serverless Compatibility Layer.

Currently all metrics (custom and standard) are bucketed into the serverless origin product. At the moment, we just want to be able to differentiate custom metrics by their source.

Motivation

SVLS-3545 - correct Serverless metric origins

Additional Notes

Will be handled in DataDog/serverless-components#5

How to test the change?

Copy the git hash to your Cargo.toml

@DylanLovesCoffee DylanLovesCoffee requested review from a team February 12, 2025 20:49
@duncanpharvey
Copy link
Copy Markdown
Contributor

Can we get Azure Functions in on this?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 89.79592% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.91%. Comparing base (b65feff) to head (d720dd8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   72.88%   72.91%   +0.03%     
==========================================
  Files         334      335       +1     
  Lines       51020    51166     +146     
==========================================
+ Hits        37184    37306     +122     
- Misses      13836    13860      +24     
Components Coverage Δ
crashtracker 42.77% <ø> (-0.06%) ⬇️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.96% <ø> (ø)
data-pipeline-ffi 90.29% <ø> (ø)
ddcommon 81.37% <ø> (ø)
ddcommon-ffi 66.10% <ø> (ø)
ddtelemetry 61.87% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.61% <89.79%> (+<0.01%) ⬆️
dogstatsd-client 82.57% <ø> (ø)
ipc 82.41% <ø> (ø)
profiling 81.89% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 41.53% <ø> (ø)
sidecar-ffi 5.58% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 91.24% <ø> (ø)
trace-mini-agent 74.66% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.13% <ø> (ø)
trace-utils 92.87% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DylanLovesCoffee
Copy link
Copy Markdown
Author

Can we get Azure Functions in on this?

Yup, we can do this but will require some updates on the backend before it's available.

Comment thread dogstatsd/src/aggregator.rs Outdated
Comment thread dogstatsd/src/aggregator.rs Outdated
Comment thread dogstatsd/src/metric.rs Outdated
Comment thread dogstatsd/src/metric.rs Outdated
Comment thread dogstatsd/src/origin.rs Outdated
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 18, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-03-20 12:10:18

Comparing candidate commit d720dd8 in PR branch dylan/metric-origins with baseline commit b65feff in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 244.921ns 253.749ns ± 11.545ns 247.626ns ± 1.498ns 256.903ns 280.317ns 282.984ns 285.563ns 15.32% 1.408 0.438 4.54% 0.816ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.149ns; 255.349ns] or [-0.631%; +0.631%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.914µs ± 0.003µs 3.915µs ± 0.001µs 3.916µs 3.918µs 3.920µs 3.921µs 0.17% -1.939 11.148 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255026339.579op/s 255479059.602op/s ± 183792.655op/s 255459931.110op/s ± 93675.774op/s 255556062.645op/s 255797738.370op/s 255875992.884op/s 256777055.005op/s 0.52% 1.959 11.318 0.07% 12996.103op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.658µs 82.063µs ± 0.220µs 81.996µs ± 0.133µs 82.191µs 82.465µs 82.795µs 82.881µs 1.08% 1.103 1.355 0.27% 0.016µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12065541.604op/s 12185859.235op/s ± 32578.771op/s 12195654.080op/s ± 19748.321op/s 12208595.462op/s 12223629.560op/s 12234397.273op/s 12246231.975op/s 0.41% -1.086 1.298 0.27% 2303.667op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.355µs 76.811µs ± 0.321µs 76.764µs ± 0.211µs 76.975µs 77.348µs 77.749µs 78.638µs 2.44% 1.563 4.868 0.42% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12716526.777op/s 13019234.412op/s ± 53985.319op/s 13027012.268op/s ± 35852.268op/s 13062594.611op/s 13080834.953op/s 13089642.242op/s 13096755.934op/s 0.54% -1.509 4.520 0.41% 3817.338op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.897µs 3.914µs ± 0.003µs 3.914µs ± 0.002µs 3.916µs 3.920µs 3.922µs 3.923µs 0.24% -0.245 3.123 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254877117.519op/s 255482049.614op/s ± 221296.395op/s 255477281.494op/s ± 142171.149op/s 255627390.489op/s 255785906.546op/s 255885874.944op/s 256634519.411op/s 0.45% 0.258 3.173 0.09% 15648.018op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.892µs 72.291µs ± 0.287µs 72.283µs ± 0.218µs 72.451µs 72.770µs 73.111µs 73.356µs 1.49% 0.794 0.370 0.40% 0.020µs 1 200
credit_card/is_card_number/378282246310005 throughput 13632084.553op/s 13833137.619op/s ± 54817.824op/s 13834595.567op/s ± 41677.474op/s 13881486.294op/s 13898126.328op/s 13905854.622op/s 13909785.534op/s 0.54% -0.773 0.306 0.40% 3876.206op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.840µs 52.135µs ± 0.126µs 52.132µs ± 0.059µs 52.188µs 52.280µs 52.429µs 53.092µs 1.84% 3.059 20.593 0.24% 0.009µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18835277.454op/s 19181116.728op/s ± 46190.068op/s 19182082.991op/s ± 21576.014op/s 19205692.571op/s 19235901.797op/s 19276044.149op/s 19289980.041op/s 0.56% -2.964 19.790 0.24% 3266.131op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.430µs 6.448µs ± 0.026µs 6.442µs ± 0.003µs 6.445µs 6.487µs 6.580µs 6.647µs 3.18% 4.991 28.232 0.40% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 150452714.446op/s 155094415.081op/s ± 606762.386op/s 155234553.113op/s ± 64833.455op/s 155294696.687op/s 155404395.267op/s 155472703.035op/s 155531804.602op/s 0.19% -4.928 27.504 0.39% 42904.580op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.898µs 3.914µs ± 0.003µs 3.915µs ± 0.002µs 3.916µs 3.919µs 3.920µs 3.930µs 0.40% -0.124 5.990 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254441371.231op/s 255477631.726op/s ± 201389.059op/s 255457875.002op/s ± 104077.818op/s 255586266.758op/s 255759533.272op/s 255864820.779op/s 256550291.237op/s 0.43% 0.143 5.995 0.08% 14240.357op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.975µs 64.247µs ± 0.113µs 64.238µs ± 0.047µs 64.281µs 64.435µs 64.670µs 64.703µs 0.72% 1.702 4.702 0.17% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15455301.287op/s 15564907.557op/s ± 27223.583op/s 15567135.442op/s ± 11301.665op/s 15578712.468op/s 15599983.698op/s 15609415.604op/s 15631226.501op/s 0.41% -1.683 4.634 0.17% 1924.998op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.166µs 58.287µs ± 0.095µs 58.266µs ± 0.036µs 58.311µs 58.429µs 58.631µs 59.019µs 1.29% 3.406 18.788 0.16% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16943681.076op/s 17156524.027op/s ± 27867.571op/s 17162703.730op/s ± 10464.996op/s 17170927.902op/s 17183907.529op/s 17189563.855op/s 17192143.191op/s 0.17% -3.361 18.330 0.16% 1970.535op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.901µs 3.913µs ± 0.003µs 3.914µs ± 0.002µs 3.915µs 3.917µs 3.920µs 3.928µs 0.36% 0.248 3.396 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254598162.389op/s 255544288.426op/s ± 191484.317op/s 255512098.522op/s ± 124695.950op/s 255692184.646op/s 255828701.512op/s 255904677.179op/s 256372486.847op/s 0.34% -0.236 3.377 0.07% 13539.986op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.548µs 54.744µs ± 0.218µs 54.657µs ± 0.045µs 54.725µs 55.187µs 55.549µs 55.646µs 1.81% 2.086 3.999 0.40% 0.015µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17970621.863op/s 18267235.834op/s ± 72020.174op/s 18295861.476op/s ± 15228.637op/s 18307475.400op/s 18323462.187op/s 18327613.060op/s 18332529.240op/s 0.20% -2.067 3.887 0.39% 5092.595op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.809µs 52.127µs ± 0.111µs 52.144µs ± 0.075µs 52.202µs 52.288µs 52.350µs 52.374µs 0.44% -0.410 -0.291 0.21% 0.008µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19093335.084op/s 19184064.127op/s ± 41041.154op/s 19177488.521op/s ± 27494.892op/s 19212469.379op/s 19259761.697op/s 19278336.470op/s 19301834.549op/s 0.65% 0.419 -0.284 0.21% 2902.048op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.430µs 6.444µs ± 0.018µs 6.442µs ± 0.003µs 6.445µs 6.456µs 6.505µs 6.624µs 2.83% 7.277 63.208 0.28% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 150959726.706op/s 155183793.911op/s ± 420965.646op/s 155236772.063op/s ± 78151.977op/s 155321655.748op/s 155452429.659op/s 155494952.574op/s 155525885.797op/s 0.19% -7.177 61.725 0.27% 29766.766op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255453587.707op/s; 255504531.496op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.032µs; 82.093µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12181344.131op/s; 12190374.340op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [76.766µs; 76.855µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13011752.566op/s; 13026716.258op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.915µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [255451380.062op/s; 255512719.166op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.251µs; 72.331µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/378282246310005 throughput [13825540.396op/s; 13840734.843op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.117µs; 52.152µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19174715.229op/s; 19187518.227op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.444µs; 6.451µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/x371413321323331 throughput [155010323.650op/s; 155178506.512op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.915µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255449721.139op/s; 255505542.312op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.232µs; 64.263µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15561134.631op/s; 15568680.484op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.274µs; 58.300µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17152661.850op/s; 17160386.204op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255517750.541op/s; 255570826.310op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.714µs; 54.774µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18257254.530op/s; 18277217.137op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.111µs; 52.142µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19178376.217op/s; 19189752.036op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.442µs; 6.446µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155125452.121op/s; 155242135.701op/s] or [-0.038%; +0.038%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.659µs 209.062µs ± 0.156µs 209.066µs ± 0.102µs 209.167µs 209.313µs 209.366µs 209.422µs 0.17% -0.236 -0.282 0.07% 0.011µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4775043.712op/s 4783282.107op/s ± 3580.470op/s 4783173.116op/s ± 2327.619op/s 4785527.130op/s 4789828.735op/s 4791853.185op/s 4792514.093op/s 0.20% 0.239 -0.280 0.07% 253.177op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.233µs 18.313µs ± 0.050µs 18.322µs ± 0.032µs 18.344µs 18.387µs 18.401µs 18.518µs 1.07% 0.349 1.025 0.27% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54001242.482op/s 54605880.105op/s ± 147607.104op/s 54578756.351op/s ± 94558.006op/s 54722342.742op/s 54836312.801op/s 54842529.700op/s 54845811.831op/s 0.49% -0.326 0.945 0.27% 10437.398op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.660µs 10.715µs ± 0.029µs 10.712µs ± 0.016µs 10.729µs 10.761µs 10.799µs 10.884µs 1.61% 1.390 5.628 0.27% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 91879804.254op/s 93329837.140op/s ± 248104.778op/s 93356231.948op/s ± 141761.062op/s 93477398.789op/s 93669009.037op/s 93794909.732op/s 93811067.397op/s 0.49% -1.345 5.351 0.27% 17543.657op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.040µs; 209.083µs] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4782785.888op/s; 4783778.326op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.306µs; 18.320µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54585423.180op/s; 54626337.030op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.711µs; 10.719µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good throughput [93295452.203op/s; 93364222.076op/s] or [-0.037%; +0.037%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.386µs 2.417µs ± 0.025µs 2.410µs ± 0.010µs 2.422µs 2.490µs 2.495µs 2.498µs 3.65% 1.886 3.277 1.04% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.413µs; 2.420µs] or [-0.144%; +0.144%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.925µs 4.995µs ± 0.050µs 4.969µs ± 0.020µs 5.050µs 5.079µs 5.083µs 5.088µs 2.41% 0.583 -1.318 1.00% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.988µs; 5.002µs] or [-0.140%; +0.140%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.016ms 6.028ms ± 0.006ms 6.028ms ± 0.003ms 6.031ms 6.037ms 6.040ms 6.068ms 0.66% 1.994 10.386 0.10% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.027ms; 6.029ms] or [-0.014%; +0.014%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 66.316µs 66.584µs ± 0.241µs 66.542µs ± 0.099µs 66.655µs 66.880µs 67.073µs 69.166µs 3.94% 6.509 64.980 0.36% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [66.551µs; 66.618µs] or [-0.050%; +0.050%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 31.638µs 32.634µs ± 1.353µs 31.793µs ± 0.082µs 34.344µs 34.887µs 35.003µs 36.453µs 14.66% 0.955 -0.945 4.14% 0.096µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [32.446µs; 32.821µs] or [-0.575%; +0.575%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 503.986µs 505.455µs ± 0.444µs 505.451µs ± 0.269µs 505.691µs 506.193µs 506.732µs 506.955µs 0.30% 0.276 0.951 0.09% 0.031µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1972559.938op/s 1978418.360op/s ± 1738.986op/s 1978430.274op/s ± 1055.109op/s 1979528.160op/s 1981266.312op/s 1981861.208op/s 1984180.788op/s 0.29% -0.269 0.946 0.09% 122.965op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.477µs 453.313µs ± 0.335µs 453.310µs ± 0.223µs 453.496µs 453.849µs 454.143µs 454.387µs 0.24% 0.269 0.173 0.07% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2200767.952op/s 2205980.899op/s ± 1628.653op/s 2205994.744op/s ± 1085.700op/s 2207145.739op/s 2208491.694op/s 2209516.557op/s 2210058.371op/s 0.18% -0.264 0.169 0.07% 115.163op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.516µs 176.563µs ± 0.393µs 176.583µs ± 0.280µs 176.861µs 177.117µs 177.257µs 177.597µs 0.57% -0.427 -0.169 0.22% 0.028µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5630724.971op/s 5663729.341op/s ± 12616.257op/s 5663066.343op/s ± 8953.781op/s 5671638.399op/s 5686725.704op/s 5695360.822op/s 5697494.978op/s 0.61% 0.438 -0.159 0.22% 892.104op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.511µs 37.655µs ± 0.059µs 37.656µs ± 0.038µs 37.691µs 37.766µs 37.815µs 37.849µs 0.51% 0.352 0.528 0.16% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26420732.656op/s 26557113.262op/s ± 41834.469op/s 26556447.126op/s ± 26765.952op/s 26585624.822op/s 26617910.834op/s 26653805.197op/s 26658681.462op/s 0.38% -0.340 0.515 0.16% 2958.144op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.100µs 48.323µs ± 0.212µs 48.334µs ± 0.224µs 48.533µs 48.607µs 48.685µs 48.717µs 0.79% 0.135 -1.754 0.44% 0.015µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20526766.452op/s 20694530.595op/s ± 90553.871op/s 20689339.813op/s ± 96302.653op/s 20786265.624op/s 20788043.905op/s 20788809.063op/s 20790073.037op/s 0.49% -0.132 -1.758 0.44% 6403.126op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.393µs; 505.516µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1978177.353op/s; 1978659.366op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.267µs; 453.360µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2205755.183op/s; 2206206.614op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.509µs; 176.617µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5661980.849op/s; 5665477.833op/s] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.647µs; 37.663µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26551315.407op/s; 26562911.117op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.294µs; 48.352µs] or [-0.061%; +0.061%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20681980.700op/s; 20707080.491op/s] or [-0.061%; +0.061%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.616µs 26.154µs ± 11.390µs 17.880µs ± 0.139µs 35.498µs 45.495µs 47.098µs 91.454µs 411.48% 1.761 5.802 43.44% 0.805µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.576µs; 27.733µs] or [-6.035%; +6.035%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.186µs 3.196µs ± 1.421µs 3.005µs ± 0.029µs 3.030µs 3.668µs 13.877µs 14.948µs 397.40% 7.368 55.391 44.34% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.999µs; 3.393µs] or [-6.161%; +6.161%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 147.790µs 148.717µs ± 0.276µs 148.670µs ± 0.135µs 148.831µs 149.145µs 149.777µs 150.066µs 0.94% 1.336 4.911 0.18% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [148.679µs; 148.756µs] or [-0.026%; +0.026%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz d720dd8 1742471923 dylan/metric-origins
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 55.472ms 55.902ms ± 0.230ms 55.879ms ± 0.112ms 55.990ms 56.311ms 56.718ms 57.061ms 2.12% 1.549 4.892 0.41% 0.016ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [55.870ms; 55.933ms] or [-0.057%; +0.057%] None None None

Baseline

Omitted due to size.

Comment thread dogstatsd/src/origin.rs Outdated
Comment thread dogstatsd/src/origin.rs Outdated
Comment thread dogstatsd/src/origin.rs Outdated
Comment thread dogstatsd/src/origin.rs Outdated
Comment thread dogstatsd/src/origin.rs Outdated
@hghotra hghotra marked this pull request as ready for review March 13, 2025 05:05
@hghotra hghotra requested a review from a team as a code owner March 13, 2025 05:05
@r1viollet
Copy link
Copy Markdown
Contributor

r1viollet commented Mar 16, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.80 MB 7.80 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 24.63 MB 24.63 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 78.56 MB 78.56 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.73 MB 7.73 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 73.03 MB 73.03 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.27 MB 23.27 MB 0% (0 B) 👌
i686-alpine-linux-musl
Artifact Baseline Commit Change
/i686-alpine-linux-musl/lib/libdatadog_profiling.a 67.89 MB 67.89 MB 0% (0 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so 8.27 MB 8.27 MB 0% (0 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.80 MB 23.80 MB 0% (0 B) 👌
i686-unknown-linux-gnu
Artifact Baseline Commit Change
/i686-unknown-linux-gnu/lib/libdatadog_profiling.a 68.81 MB 68.81 MB 0% (0 B) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so 8.15 MB 8.15 MB 0% (0 B) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 21.43 MB 21.43 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 17.18 MB 17.18 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 54.81 KB 54.81 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 116.94 MB 116.95 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 699.16 MB 699.16 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.05 MB 5.05 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 54.81 KB 54.81 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 16.28 MB 16.28 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.96 MB 26.96 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.58 MB 14.58 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 55.66 KB 55.66 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 118.98 MB 118.99 MB +.01% (+16.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 690.65 MB 690.65 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.84 MB 3.84 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 55.66 KB 55.66 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.96 MB 16.96 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.96 MB 24.96 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 67.89 MB 67.89 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.27 MB 8.27 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.80 MB 23.80 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 68.81 MB 68.81 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.15 MB 8.15 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 21.43 MB 21.43 MB 0% (0 B) 👌

@duncanpharvey
Copy link
Copy Markdown
Contributor

Closing as this change will be handled in DataDog/serverless-components#5

@dd-devflow dd-devflow Bot deleted the dylan/metric-origins branch June 20, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants