Remove Serverless Specific DogStatsD Server Implementation#973
Merged
duncanpharvey merged 5 commits intomainfrom Mar 26, 2025
Merged
Remove Serverless Specific DogStatsD Server Implementation#973duncanpharvey merged 5 commits intomainfrom
duncanpharvey merged 5 commits intomainfrom
Conversation
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
i686-alpine-linux-musl
i686-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
duncanpharvey
force-pushed
the
duncan-harvey/remove-dogstatsd
branch
from
2e20bc3 to
1373619
Compare
BenchmarksComparisonBenchmark execution time: 2025-03-26 17:36:50 Comparing candidate commit 0f2176f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
duncanista
reviewed
Mar 25, 2025
| datadog-trace-protobuf = { path = "../trace-protobuf" } | ||
| datadog-trace-utils = { path = "../trace-utils" } | ||
| dogstatsd = { path = "../dogstatsd" } | ||
| dogstatsd = { version = "0.1.0", default-features = false, git = "https://github.com/DataDog/serverless-components/", rev = "4dfe72ab1850680f41dd79d30a937eb68e7ba6da" } |
Contributor
There was a problem hiding this comment.
do you need the rev here? just curious, not sure how it works when you have both version and a git rev
Contributor
Author
There was a problem hiding this comment.
Good point! It looks like the version is ignored when the git rev is specified. The dogstatsd version still shows up in Cargo.lock so it doesn't need to be specified in Cargo.toml. I just pushed a change to remove it
duncanista
approved these changes
Mar 25, 2025
| datadog-trace-protobuf = { path = "../trace-protobuf" } | ||
| datadog-trace-utils = { path = "../trace-utils" } | ||
| dogstatsd = { path = "../dogstatsd" } | ||
| dogstatsd = { git = "https://github.com/DataDog/serverless-components/", rev = "4dfe72ab1850680f41dd79d30a937eb68e7ba6da", default-features = false } |
Contributor
There was a problem hiding this comment.
do we have to use commit hashes? can we use tags instead? for human-readability
Contributor
There was a problem hiding this comment.
or, even better, can we version the dogstatsd library?
Contributor
Author
There was a problem hiding this comment.
Eventually the plan is to have both the serverless binary crate and the dogstatsd crate in the serverless-components repo together in a mono repo approach. So for now we don't plan on versioning dogstatsd. Pinning to the commit hash in the other repo is just a temporary solution until the crates can reference in each other in the same repo.
duncanpharvey
added a commit
that referenced
this pull request
Apr 16, 2025
* remove serverless specific dogstatsd server implementation * remove dogstatsd version from dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes Serverless specific DogStatsD server implementation and updates the Serverless Mini Agent to use the crate in the serverless-components repo.
Motivation
Move Serverless specific implementations to a separate repo.
https://datadoghq.atlassian.net/browse/SVLS-6327
Additional Notes
Migrated to serverless-components in this PR: DataDog/serverless-components#2
How to test the change?
Rebuild mini agent and deploy to Azure Functions.