Conversation
r1viollet
commented
Aug 1, 2023
danielsn
reviewed
Aug 1, 2023
| while time() < end: | ||
| a() | ||
| b() | ||
| print(x) |
There was a problem hiding this comment.
I assume this is needed to avoid the compiler optimizing away the writes to x?
Collaborator
Author
There was a problem hiding this comment.
Yes, locals would be optimized without a usage in more recent python versions.
There was a problem hiding this comment.
Might want to add a comment explaining this.
danielsn
approved these changes
Aug 3, 2023
danielsn
left a comment
danielsn
left a comment
There was a problem hiding this comment.
Its nice to have a test for this. I had a minor ⛏️ about commenting the need for the print(x) but otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When moving to the docker implementation of tests, we removed the python test.
This adds it back in.
Naming adjustment: ensure we explicitly have the unit in the EXECUTION_TIME_SEC variable.