feat(find): add --help, -type b/c, -perm, -quit; fix access TOCTOU#104

Merged

matt-dz merged 43 commits intomainfrom

find-help-and-type-bc

Mar 18, 2026

Commits on Mar 17, 2026

feat(find): add --help flag and -type b,c support

matt-dz
and
claude
committed
test(find): add tests for -type b,c block/char device support

matt-dz
and
claude
committed
feat(find): add 21 GNU find predicates for comprehensive file search

matt-dz
and
claude
committed
fix: add new find predicate symbols to the allowlist

matt-dz
and
claude
committed
[iter 1] Fix review findings: samefile cache, user/group error dedup, -ls blocks, -printf directives

matt-dz
and
claude
committed
[iter 1] Fix Windows CI: add stdout_windows for perm/executable tests

matt-dz
and
claude
committed
[iter 3] Fix codex review: -perm special bits, -quit as action, -user eager validation

matt-dz
and
claude
committed
Address codex review: -xdev evaluate before skip, -samefile errors, symbolic = overwrite

matt-dz
and
claude
committed
refactor(find): gut low-value predicates, keep only agent-useful flags

matt-dz
and
claude
committed
refactor(find): remove -printf — -print and -print0 suffice

matt-dz
and
claude
committed
fix(find): -perm special bits (setuid/setgid/sticky) and symbolic s/t

matt-dz
and
claude
committed
Address codex review: enable bash parity, remove -H from usage

matt-dz
and
claude
committed
Address codex review: fix symbolic = clearing special bits, add tests

matt-dz
and
claude
committed
fix(find): remove incorrect stdout_windows from perm_any_write test

matt-dz
and
claude
committed
Address codex review: --help after paths, re-enable bash parity

matt-dz
and
claude
committed
docs(find): note unsupported GNU symbolic mode extensions

matt-dz
and
claude
committed
Address codex review: revert --help expression scan, fix quit test order

matt-dz
and
claude
committed
fix(find): recognize --help after path operands via parsePrimary

matt-dz
and
claude
committed
fix(find): use non-blocking stat-based readability checks for -readable

matt-dz
and
claude
committed
fix(access): preserve root read/write bypass in permission checks

matt-dz
and
claude
committed
feat(find): support GNU symbolic mode copy-bits and conditional execute in -perm

matt-dz
and
claude
committed
fix(find): add --help to help output, fix Windows perm test failures

matt-dz
and
claude
committed
fix(find): respect who mask when applying symbolic sticky bit

matt-dz
and
claude
committed
Merge branch 'main' of github.com:DataDog/rshell into find-help-and-type-bc
matt-dz
committed
fix(access): use kernel access(2) for permission checks instead of mode bits

matt-dz
and
claude
committed
fix(access): guard accessCheck by accepting root + rel separately

matt-dz
and
claude
committed
fix(access): use OpenFile for Windows read checks, bind accessCheck to root

matt-dz
and
claude
committed
fix(access): eliminate TOCTOU by keeping all permission checks fd-relative

matt-dz
and
claude
committed
fix(access): open-first with O_NONBLOCK to eliminate Stat→OpenFile TOCTOU

matt-dz
and
claude
committed
fix(find): stop treating -quit as implicit-print suppressor

matt-dz
and
claude
committed
fix(ci): deny execute checks on Windows, add golang.org/x/sys to license CSV

matt-dz
and
claude
committed
test: add skip_if_root to scenario framework; guard readable_not_readable

matt-dz
and
claude
committed
test: guard test_write_denied scenario against root execution

matt-dz
and
claude
committed

Commits on Mar 18, 2026