refactor: capture time.Now() once at shell start, add NowSafe() guard, fix fuzz test context leaks#117

Merged

AlexandreYang merged 27 commits intomainfrom

alex/time_now-v2

Mar 18, 2026

Commits on Mar 17, 2026

refactor: capture time.Now() once at shell start and pass as CallContext.Now value

AlexandreYang
and
claude
committed
[iter 1] fix: propagate startTime into subshell child runners

AlexandreYang
and
claude
committed
[iter 1] fix: add time.Time to interp allowed symbols

AlexandreYang
and
claude
committed

Commits on Mar 18, 2026

[iter 22] Address self-review: document time divergence and strengthen now test

AlexandreYang
and
claude
committed
[iter 22] Fix FuzzLsHumanReadable flakiness: use context.Background() for per-iteration timeouts

AlexandreYang
and
claude
committed
[iter 23] fix: drop misleading IsZero fallback note from CallContext.Now doc comment
AlexandreYang
committed
[iter 4] fix: call cancel() immediately after use in fuzz tests to avoid context leak

AlexandreYang
and
claude
committed
[iter 5] docs: document Now zero-value footgun and startTime reset invariant

AlexandreYang
and
claude
committed
[iter 6] Add NowSafe() guard and fix TestNowConsistentAcrossRoots comment

AlexandreYang
and
claude
committed
[iter 7] Add unit tests for CallContext.NowSafe panic and happy path

AlexandreYang
and
claude
committed
[iter 8] doc: clarify NowSafe() zero-value sentinel limitation

AlexandreYang
and
claude
committed
[iter 21] doc: update Now field comment to reference NowSafe() guard
AlexandreYang
committed
[iter 21] fix: use context.Background() and immediate cancel() in all fuzz tests
AlexandreYang
committed
[iter 22] fix: correct cancel() ordering in grep/testcmd/cut/ip fuzz tests
AlexandreYang
committed
[iter 23] Address self-review: document time divergence and strengthen now test
AlexandreYang
committed
[iter 24] fix: capture timeout before cancel in ip fuzz tests; polish docs
AlexandreYang
committed
[iter 24] fix: restore 50ms sleep in TestStartTimeUpdatesOnSubsequentRun for Windows

AlexandreYang
and
claude
committed
[iter 25] ci: retrigger to address FuzzTestStringUnary flake

AlexandreYang
and
claude
committed
[iter 25] doc: clarify NowSafe panic recovery and dual-context fuzz pattern

AlexandreYang
and
claude
committed
[iter 26] fix: broaden NowSafe panic message and restore defer cancel() safety net

AlexandreYang
and
claude
committed
[iter 26] ci: retrigger to address FuzzCmdSubstNested flake

AlexandreYang
and
claude
committed
[iter 27] doc: clarify NowSafe guard is for direct callers only

AlexandreYang
and
claude
committed
[iter 29] fix: use callCtx.Now directly in find/ls per SPEC

AlexandreYang
and
claude
committed
[iter 29] ci: retrigger to address FuzzGrepFlags flake
AlexandreYang
committed
[iter 29] ci: retrigger to address FuzzTailLinesOffset flake
AlexandreYang
committed
[iter 29] ci: retrigger to address FuzzGrepFixedStrings flake
AlexandreYang
committed
remove NowSafe helper

AlexandreYang
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: capture time.Now() once at shell start, add NowSafe() guard, fix fuzz test context leaks#117

refactor: capture time.Now() once at shell start, add NowSafe() guard, fix fuzz test context leaks#117
AlexandreYang merged 27 commits intomainfrom
alex/time_now-v2

Commits on Mar 17, 2026

refactor: capture time.Now() once at shell start and pass as CallContext.Now value

[iter 1] fix: propagate startTime into subshell child runners

[iter 1] fix: add time.Time to interp allowed symbols

Commits on Mar 18, 2026

[iter 22] Address self-review: document time divergence and strengthen now test

[iter 22] Fix FuzzLsHumanReadable flakiness: use context.Background() for per-iteration timeouts

[iter 23] fix: drop misleading IsZero fallback note from CallContext.Now doc comment

[iter 4] fix: call cancel() immediately after use in fuzz tests to avoid context leak

[iter 5] docs: document Now zero-value footgun and startTime reset invariant

[iter 6] Add NowSafe() guard and fix TestNowConsistentAcrossRoots comment

[iter 7] Add unit tests for CallContext.NowSafe panic and happy path

[iter 8] doc: clarify NowSafe() zero-value sentinel limitation

[iter 21] doc: update Now field comment to reference NowSafe() guard

[iter 21] fix: use context.Background() and immediate cancel() in all fuzz tests

[iter 22] fix: correct cancel() ordering in grep/testcmd/cut/ip fuzz tests

[iter 23] Address self-review: document time divergence and strengthen now test

[iter 24] fix: capture timeout before cancel in ip fuzz tests; polish docs

[iter 24] fix: restore 50ms sleep in TestStartTimeUpdatesOnSubsequentRun for Windows

[iter 25] ci: retrigger to address FuzzTestStringUnary flake

[iter 25] doc: clarify NowSafe panic recovery and dual-context fuzz pattern

[iter 26] fix: broaden NowSafe panic message and restore defer cancel() safety net

[iter 26] ci: retrigger to address FuzzCmdSubstNested flake

[iter 27] doc: clarify NowSafe guard is for direct callers only

[iter 29] fix: use callCtx.Now directly in find/ls per SPEC

[iter 29] ci: retrigger to address FuzzGrepFlags flake

[iter 29] ci: retrigger to address FuzzTailLinesOffset flake

[iter 29] ci: retrigger to address FuzzGrepFixedStrings flake

remove NowSafe helper