feat(ps): add --proc-path parameter to CLI and API#127

Merged

AlexandreYang merged 29 commits intomainfrom

alex/proc_path

Mar 19, 2026

Commits on Mar 18, 2026

feat(ps): add --proc-path parameter to CLI and API for configurable proc filesystem path

AlexandreYang
and
claude
committed
refactor(ps): use filepath.Join for proc path manipulation

AlexandreYang
and
claude
committed
refactor(ps): use proper multi-segment filepath.Join for proc path construction

AlexandreYang
and
claude
committed
test(ps): add ProcPath API and --proc-path CLI coverage

AlexandreYang
and
claude
committed
refactor(procinfo): extract resolveProcPath to remove duplicated default logic

AlexandreYang
and
claude
committed
[iter 1] Address review comments: ProcProvider, fix pid in writeFakeProc, add session test, update docs

AlexandreYang
and
claude
committed
Address review: surface proc-path errors in getByPIDs

AlexandreYang
and
claude
committed
perf(procinfo): replace ReadDir with Stat for proc root validation

AlexandreYang
and
claude
committed
perf(interp): cache ProcProvider in runnerConfig; fix os.Stat allowlist

AlexandreYang
and
claude
committed
fix(procinfo): reject non-directory proc-path in getByPIDs

AlexandreYang
and
claude
committed
test(procinfo): add coverage for non-directory proc-path in ps -e and ps -p

AlexandreYang
and
claude
committed
test(cmd): add positive --proc-path CLI test with fake proc tree

AlexandreYang
and
claude
committed
chore: remove address-pr-comments skill

AlexandreYang
and
claude
committed
chore(skill): replace @codex PR comment with local codex CLI review in review-fix-loop

AlexandreYang
and
claude
committed
chore(skill): remove address-pr-comments references from review-fix-loop

AlexandreYang
and
claude
committed
chore(skill): remove PR comment reading/resolving from fix-ci-tests

AlexandreYang
and
claude
committed
chore(skill): remove SPECS prompt injection vector from code-review

AlexandreYang
and
claude
committed
chore(skill): post codex review as separate PR comment in review-fix-loop

AlexandreYang
and
claude
committed
[iter 1] Fix prompt injection in review-fix-loop, add ProcPath docs, use testify in ps test

AlexandreYang
and
claude
committed
chore(skill): use structured findings format for self-review and codex review comments

AlexandreYang
and
claude
committed
chore(skill): include total iteration count in review comment headers

AlexandreYang
and
claude
committed
[iter 2] Surface non-ENOENT errors in getByPIDs; fix stale codex gate in review-fix-loop

AlexandreYang
and
claude
committed
fix: add errors.Is and os.ErrNotExist to procinfo allowlist

AlexandreYang
and
claude
committed
chore: use filepath.Join in ps error msg; clarify ProcPath docs; update review-fix-loop to use RULES.md

AlexandreYang
and
claude
committed
[iter 2] Fix ProcPath godoc, error format, remove unresolved-threads gate from review-fix-loop

AlexandreYang
and
claude
committed
fix: add codex fallback to @bot; restore SPECS verification in code-review

AlexandreYang
and
claude
committed
chore: remove @codex bot fallback; skip sub-step when codex unavailable

AlexandreYang
and
claude
committed
chore: remove SPECS verification step from code-review skill

AlexandreYang
and
claude
committed
[iter 1] Strengthen TestProcPathFakeProcSession assertion; document PID-namespace caveat

AlexandreYang
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ps): add --proc-path parameter to CLI and API#127

feat(ps): add --proc-path parameter to CLI and API#127
AlexandreYang merged 29 commits intomainfrom
alex/proc_path

Commits on Mar 18, 2026

feat(ps): add --proc-path parameter to CLI and API for configurable proc filesystem path

refactor(ps): use filepath.Join for proc path manipulation

refactor(ps): use proper multi-segment filepath.Join for proc path construction

test(ps): add ProcPath API and --proc-path CLI coverage

refactor(procinfo): extract resolveProcPath to remove duplicated default logic

[iter 1] Address review comments: ProcProvider, fix pid in writeFakeProc, add session test, update docs

Address review: surface proc-path errors in getByPIDs

perf(procinfo): replace ReadDir with Stat for proc root validation

perf(interp): cache ProcProvider in runnerConfig; fix os.Stat allowlist

fix(procinfo): reject non-directory proc-path in getByPIDs

test(procinfo): add coverage for non-directory proc-path in ps -e and ps -p

test(cmd): add positive --proc-path CLI test with fake proc tree

chore: remove address-pr-comments skill

chore(skill): replace @codex PR comment with local codex CLI review in review-fix-loop

chore(skill): remove address-pr-comments references from review-fix-loop

chore(skill): remove PR comment reading/resolving from fix-ci-tests

chore(skill): remove SPECS prompt injection vector from code-review

chore(skill): post codex review as separate PR comment in review-fix-loop

[iter 1] Fix prompt injection in review-fix-loop, add ProcPath docs, use testify in ps test

chore(skill): use structured findings format for self-review and codex review comments

chore(skill): include total iteration count in review comment headers

[iter 2] Surface non-ENOENT errors in getByPIDs; fix stale codex gate in review-fix-loop

fix: add errors.Is and os.ErrNotExist to procinfo allowlist

chore: use filepath.Join in ps error msg; clarify ProcPath docs; update review-fix-loop to use RULES.md

[iter 2] Fix ProcPath godoc, error format, remove unresolved-threads gate from review-fix-loop

fix: add codex fallback to @bot; restore SPECS verification in code-review

chore: remove @codex bot fallback; skip sub-step when codex unavailable

chore: remove SPECS verification step from code-review skill

[iter 1] Strengthen TestProcPathFakeProcSession assertion; document PID-namespace caveat