Implement test/[ builtin with file, string, integer, and logic operators#16
Closed
AlexandreYang wants to merge 9 commits intomainfrom
Closed
Implement test/[ builtin with file, string, integer, and logic operators#16AlexandreYang wants to merge 9 commits intomainfrom
AlexandreYang wants to merge 9 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce23d6fcb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AlexandreYang
force-pushed
the
alex/builtin_test
branch
from
ce23d6f to
3dac419
Compare
…s to scenarios Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…est scenarios Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AlexandreYang
commented
Mar 9, 2026
Comment on lines
+42
to
+49
| "os.FileInfo", | ||
| "os.ModeSymlink", | ||
| "os.O_RDONLY", | ||
| "os.SameFile", | ||
| "path/filepath.Ext", | ||
| "strconv.Atoi", | ||
| "strconv.ParseInt", | ||
| "strings.ToLower", |
Member
Author
There was a problem hiding this comment.
Should be wrapped with os.Root?
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testand[builtins supporting file tests (-e,-f,-d,-s,-L), string tests (-z,-n,=,!=), integer comparisons (-eq,-ne,-lt,-le,-gt,-ge), and logic operators (!,-a,-o, parentheses)Test plan
go test ./interp/builtins/tests/test/...go test ./tests/ -run TestShellScenariosRSHELL_BASH_TEST=1 go test ./tests/ -run TestShellScenariosAgainstBash -timeout 120s🤖 Generated with Claude Code