fix(interp): remove special case for help builtin command#176
Merged
Conversation
The help command is no longer implicitly allowed — it must be explicitly included in the AllowedCommands list like any other command. Removes the name != "help" checks from the command allowlist enforcement and the CommandAllowed callback. Closes #175 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
matt-dz
requested review from
AlexandreYang,
astuyve,
julesmcrt,
thieman and
val06
as code owners
astuyve
approved these changes
Apr 7, 2026
Tests that restricted commands but expected help to be implicitly available now explicitly include rshell:help. TestHelpAlwaysAvailable replaced with TestHelpNotAllowedWhenNotInList that verifies help is blocked when not in the allowlist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
help— it must now be explicitly included inAllowedCommandslike any other commandCommandAllowedcallbacksalways_available.yamlscenario testrestricted_commands.yamlto includershell:helpin allowed commandsCloses #175
Test plan
🤖 Generated with Claude Code