Extract filesystem sandboxing into pathSandbox#3
Merged
AlexandreYang merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
Co-authored-by: AlexandreYang <49917914+AlexandreYang@users.noreply.github.com>
This was referenced Mar 12, 2026
Merged
Closed
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the parallel
allowedPaths []string/roots []*os.Rootslices with a singlepathSandboxtype that owns both the path strings and theiros.Roothandles together. This centralizes the security boundary and removes index-coupling between the two slices.Changes
allowedRootstruct pairingabsPathwith its*os.RoothandlepathSandboxstruct withresolve,open,readDir,openRoots, andClosemethodsAllowedPathsoption now creates a*pathSandboxinstead of populating raw slicesRunner.allowedPaths+Runner.rootswith a singleRunner.sandbox *pathSandboxReset(),Close(), andsubshell()inapi.goto use the new typefindMatchingRoot,restrictedOpenHandler, andrestrictedReadDirHandlerfunctionsTesting
AllowedPaths*tests pass (18 tests)go test ./...)PR by Bits
View session in Datadog
Comment @DataDog to request changes