Split interp/runner.go into focused modules#4
Merged
AlexandreYang merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
Co-authored-by: AlexandreYang <49917914+AlexandreYang@users.noreply.github.com>
This was referenced Mar 12, 2026
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the monolithic
interp/runner.gointo three focused files to reduce cognitive load and improve navigability.Changes
runner_expand.go— expansion config, error handling,expandEnvtype (fillExpandConfig,updateExpandOpts,expandErr,fields,literal,document)runner_redir.go— redirect and heredoc logic (redir,hdocReader,isQuotedHdoc,hdocLiteral,hdocLiteralPart)runner_exec.go— statement execution, command dispatch, loops, builtins/external call (stmt,stmtSync,cmd,stmts,loopStmtsBroken,call,exec)runner.go— trimmed to shared utilities only (handlerCtx,errf,stop,open,todoPos)No logic changes — pure code reorganization.
Testing
go build ./interp/...passesgo test ./interp/...passesgo vet ./interp/...cleangofmtcleanPR by Bits
View session in Datadog
Comment @DataDog to request changes