Skip to content

Use strings.Compare in readDir sort #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexandreYang merged 1 commit into from
Mar 9, 2026
Merged

Use strings.Compare in readDir sort #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions interp/allowed_paths.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,7 @@ func (s *pathSandbox) readDir(ctx context.Context, path string) ([]fs.DirEntry,
// os.Root's ReadDir does not guarantee sorted order like os.ReadDir.
// Sort to match POSIX glob expansion expectations.
slices.SortFunc(entries, func(a, b fs.DirEntry) int {
if a.Name() < b.Name() {
return -1
}
if a.Name() > b.Name() {
return 1
}
return 0
return strings.Compare(a.Name(), b.Name())
})
return entries, nil
}
Expand Down
Loading