Harden ls builtin: symlink safety, entry limits, pentest tests#60

Merged

matt-dz merged 20 commits intomainfrom

matt-dz/harden-ls

Mar 13, 2026

Commits on Mar 12, 2026

Harden ls builtin: skip symlinks in -R, add MaxDirEntries limit, add pentest tests

matt-dz
and
claude
committed
Address review: add clarifying comment for MaxDirEntries check

matt-dz
and
claude
committed
Address review: MaxDirEntries warning instead of hard error

matt-dz
and
claude
committed
Early-exit directory counting to prevent OOM on oversized directories

matt-dz
and
claude
committed
Paginated ls with truncated output on oversized directories

matt-dz
and
claude
committed
Merge branch 'main' into matt-dz/harden-ls
matt-dz
authored
Address review: fix negative offset crash, dot-dot limit slots, swallowed ReadDir errors

matt-dz
and
claude
committed
Address review: cap offset at MaxDirEntries, decouple maxRead from offset

matt-dz
and
claude
committed
Address review: ignore --limit in recursive mode, document DoS tradeoffs

matt-dz
and
claude
committed
Address review: streaming offset for O(n) pagination, ignore pagination in multi-dir mode

matt-dz
and
claude
committed
Add comprehensive regression tests for ls pagination and DoS protection

matt-dz
and
claude
committed
Remove PR review tag comments from regression tests

matt-dz
and
claude
committed
Add ls pagination scenario tests

matt-dz
and
claude
committed
Address review: sort dot entries with other entries, continue recursion after truncation

matt-dz
and
claude
committed
Revert: keep early return after truncation, do not recurse past MaxDirEntries

matt-dz
and
claude
committed
Document intentional bash divergence: no recursion after truncation

matt-dz
and
claude
committed
Address review: preserve ReadDir errors when truncation occurs

matt-dz
and
claude
committed
Extract collectDirEntries for testability, add error-during-truncation test

matt-dz
and
claude
committed
Fix Effective Go findings: use errors.Is for EOF, pre-allocate slice

matt-dz
and
claude
committed
format files
matt-dz
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Harden ls builtin: symlink safety, entry limits, pentest tests#60

Harden ls builtin: symlink safety, entry limits, pentest tests#60
matt-dz merged 20 commits intomainfrom
matt-dz/harden-ls

Commits on Mar 12, 2026

Harden ls builtin: skip symlinks in -R, add MaxDirEntries limit, add pentest tests

Address review: add clarifying comment for MaxDirEntries check

Address review: MaxDirEntries warning instead of hard error

Early-exit directory counting to prevent OOM on oversized directories

Paginated ls with truncated output on oversized directories

Merge branch 'main' into matt-dz/harden-ls

Address review: fix negative offset crash, dot-dot limit slots, swallowed ReadDir errors

Address review: cap offset at MaxDirEntries, decouple maxRead from offset

Address review: ignore --limit in recursive mode, document DoS tradeoffs

Address review: streaming offset for O(n) pagination, ignore pagination in multi-dir mode

Add comprehensive regression tests for ls pagination and DoS protection

Remove PR review tag comments from regression tests

Add ls pagination scenario tests

Address review: sort dot entries with other entries, continue recursion after truncation

Revert: keep early return after truncation, do not recurse past MaxDirEntries

Document intentional bash divergence: no recursion after truncation

Address review: preserve ReadDir errors when truncation occurs

Extract collectDirEntries for testability, add error-during-truncation test

Fix Effective Go findings: use errors.Is for EOF, pre-allocate slice

format files