fix: enable default datadog-fips features from dogstatsd#15
Merged
duncanpharvey merged 5 commits intomainfrom May 6, 2025
Merged
Conversation
f39a2b5 to
0826e48
Compare
| regex = { version = "1.10.6", default-features = false } | ||
| zstd = { version = "0.13.3", default-features = false } | ||
| datadog-fips = { path = "../datadog-fips", default-features = false } | ||
| datadog-fips = { path = "../datadog-fips", default-features = true } |
Contributor
There was a problem hiding this comment.
this may be incorrect. we may need to select which features to include, default or not default. i'd say if you need the default feature from datadog-fips it would be better to add it to the default feature list on line 35 below
Collaborator
Author
There was a problem hiding this comment.
What about setting the default features from datadog-serverless-compat?
Contributor
There was a problem hiding this comment.
ah, that shouldn't mess with bottlecap, i think. seems fine from that perspective.
apiarian-datadog
approved these changes
May 6, 2025
Contributor
apiarian-datadog
left a comment
There was a problem hiding this comment.
looks fine from the bottlecaps and fips-ish perspective
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable default
datadog-fipsfeatures fromdogstatsd.Motivation
Error when building
datadog-serverless-compatwithout thereqwest/rustls-tlsfeature:serverless-components/crates/datadog-fips/Cargo.toml
Line 16 in 619d378
Additional Notes
ubuntu-24.04-armbuild for Datadog Serverless Compat since this architecture is not supported by Azure Functions or Google Cloud Run Functions at this timefail-fasttofalsefor Github Actions to false to allow for all jobs to run independently of other failures.Describe how to test/QA your changes
Added build step for
datadog-serverless-compatto CI to catch build errors in the future.