Skip to content

[SVLS-6337] Update the libdatadog version datadog-trace-agent is using#41

Closed
kathiehuang wants to merge 4 commits intomainfrom
update-libdatadog-hash
Closed

[SVLS-6337] Update the libdatadog version datadog-trace-agent is using#41
kathiehuang wants to merge 4 commits intomainfrom
update-libdatadog-hash

Conversation

@kathiehuang
Copy link
Copy Markdown
Contributor

@kathiehuang kathiehuang commented Oct 1, 2025

What does this PR do?

  • Updates the libdatadog commit hash in crates/datadog-trace-agent/Cargo.toml
    • This adds logic to check for DD_AZURE_RESOURCE_GROUP in Azure flex consumption functions. Without that env var, the resource group span attribute will be set to unknown. Before, the resource group span attribute would be set to flex, which is incorrect and messes up the resource id and billing

Motivation

Need to build updated binary for serverless compat layers

Describe how to test/QA your changes

Copy link
Copy Markdown
Collaborator

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with just one nit!

Comment thread license-tool.toml
# `bollard-stubs` is an autogenerated crate that doesn't have all the right metadata specified in its Cargo.toml.
"bollard-stubs-1.45.0-rc.26.0.1" = { origin = "https://github.com/fussybeaver/bollard" }
# `stringmetrics` is used in `libdatadog`, which has less stringent checks when generating 3rd party licenses.
"stringmetrics-2.2.2" = { license = "Apache-2.0", origin = "https://github.com/pluots/stringmetrics" } No newline at end of file
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: needs newline

@kathiehuang kathiehuang closed this Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants