Conversation
Lewis-E
force-pushed
the
lewis/SVLS-6029/cleanup
branch
from
c44dc74 to
e67c8d8
Compare
kathiehuang
approved these changes
Jan 6, 2026
Contributor
kathiehuang
left a comment
kathiehuang
left a comment
There was a problem hiding this comment.
Not a pro at Rust but this makes sense to me!
| @@ -1 +1,3 @@ | |||
| /target | |||
| /.idea | |||
Contributor
Author
There was a problem hiding this comment.
That is a jetbrains config file!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test_is_azure_flex_without_resource_group_truepass locally by managing environment outside of the CI/CD pipeline.Motivation
Additional Notes
An
Arc::clonecreates a new reference to whatever value it contains. We do need a new reference to bemoveed into the stats flusher, but we don't need new references fortrace_endpoint_handler-- it can just take ownership of the existing clones, as they won't be used for anything else.Describe how to test/QA your changes