Skip to content

More Integration Tests for datadog-trace-agent#62

Merged
Lewis-E merged 8 commits intomainfrom
lewis/SVLS-6029/add-bonus-tests
Feb 13, 2026
Merged

More Integration Tests for datadog-trace-agent#62
Lewis-E merged 8 commits intomainfrom
lewis/SVLS-6029/add-bonus-tests

Conversation

@Lewis-E
Copy link
Copy Markdown
Contributor

@Lewis-E Lewis-E commented Jan 9, 2026

What does this PR do?

  • Adds full integration tests that covers stat and trace flushing with TCP and Named Pipes

Motivation

Describe how to test/QA your changes

  • PR is only tests

@Lewis-E Lewis-E changed the base branch from main to lewis/SVLS-6029/trace-agent-named-pipes January 9, 2026 21:50
@Lewis-E Lewis-E force-pushed the lewis/SVLS-6029/add-bonus-tests branch 2 times, most recently from 796a6ea to b1e92ef Compare January 9, 2026 22:22
@Lewis-E Lewis-E requested a review from duncanpharvey January 20, 2026 18:54
@Lewis-E Lewis-E marked this pull request as ready for review January 20, 2026 18:54
@Lewis-E Lewis-E requested a review from a team as a code owner January 20, 2026 18:54
@Lewis-E Lewis-E force-pushed the lewis/SVLS-6029/trace-agent-named-pipes branch 3 times, most recently from 27fdcc1 to 1fc9d37 Compare January 27, 2026 19:35
Base automatically changed from lewis/SVLS-6029/trace-agent-named-pipes to main January 30, 2026 22:13
@Lewis-E Lewis-E force-pushed the lewis/SVLS-6029/add-bonus-tests branch 2 times, most recently from 43d8967 to 2282e8c Compare February 4, 2026 17:53
@Lewis-E Lewis-E force-pushed the lewis/SVLS-6029/add-bonus-tests branch from 2282e8c to 7922bac Compare February 12, 2026 15:41
@Lewis-E Lewis-E requested a review from a team as a code owner February 12, 2026 16:03
@Lewis-E Lewis-E force-pushed the lewis/SVLS-6029/add-bonus-tests branch from c8aa726 to 7dda491 Compare February 12, 2026 18:25
Copy link
Copy Markdown
Collaborator

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor comments and questions

Comment thread crates/datadog-serverless-compat/src/main.rs
Comment thread crates/datadog-trace-agent/tests/integration_test.rs
Comment thread crates/datadog-trace-agent/tests/integration_test.rs
@Lewis-E Lewis-E merged commit 5d332f8 into main Feb 13, 2026
26 checks passed
@Lewis-E Lewis-E deleted the lewis/SVLS-6029/add-bonus-tests branch February 13, 2026 20:19
@kathiehuang
Copy link
Copy Markdown
Contributor

I got this error when trying to build from main:

error[E0063]: missing field `so_rcvbuf` in initializer of `DogStatsDConfig`
   --> crates/datadog-serverless-compat/src/main.rs:239:28
    |
239 |     let dogstatsd_config = DogStatsDConfig {
    |                            ^^^^^^^^^^^^^^^ missing `so_rcvbuf`

For more information about this error, try `rustc --explain E0063`.

It seems to have just happened to conflict with the previous commit 383fd14 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants