fix(dogstatsd): Move Windows Named Pipes into a Cargo Feature#70
fix(dogstatsd): Move Windows Named Pipes into a Cargo Feature#70
Conversation
19cf951 to
58b6166
Compare
There was a problem hiding this comment.
I think this might be missing the field to be marked as a feature in the constructor of dogstatsd?
There was a problem hiding this comment.
Not quite LLM 2-shotted :)
duncanista
left a comment
There was a problem hiding this comment.
Looks good on the dogstatsd side, left a comment – not sure if you need the feature on the other crates? But I really don't understand how and where those products are used
901ff28 to
c9f6a91
Compare
duncanista
left a comment
There was a problem hiding this comment.
LGTM on the dogstatsd side
There was a problem hiding this comment.
Pull request overview
This PR moves Windows named-pipe support behind an explicit windows-pipes Cargo feature so non-Windows/AWS builds can exclude named-pipe code (and related Tokio features) at compile time.
Changes:
- Added
windows-pipesfeature flags and updated#[cfg(...)]guards across crates/tests. - Reduced default Tokio features in
dogstatsd, enablingio-utilonly whenwindows-pipesis enabled. - Updated Windows CI build for
datadog-serverless-compatto build with--features windows-pipes.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/dogstatsd/tests/integration_test.rs | Gate named-pipe tests/imports and config fields behind windows-pipes. |
| crates/dogstatsd/src/dogstatsd.rs | Gate named-pipe transport types/logic behind windows-pipes. |
| crates/dogstatsd/Cargo.toml | Add windows-pipes feature; move tokio/io-util behind feature. |
| crates/datadog-trace-agent/tests/integration_test.rs | Gate named-pipe test/helpers and config fields behind windows-pipes. |
| crates/datadog-trace-agent/tests/common/helpers.rs | Gate named-pipe helper behind windows-pipes. |
| crates/datadog-trace-agent/src/trace_processor.rs | Conditionally include Windows pipe config fields in unit-test config. |
| crates/datadog-trace-agent/src/mini_agent.rs | Gate named-pipe server import/serve logic behind windows-pipes and adjust config handling. |
| crates/datadog-trace-agent/src/config.rs | Gate Windows pipe config fields/env parsing behind windows-pipes (and test). |
| crates/datadog-trace-agent/Cargo.toml | Introduce windows-pipes feature flag. |
| crates/datadog-serverless-compat/src/main.rs | Gate reading/passing named-pipe config behind windows-pipes. |
| crates/datadog-serverless-compat/Cargo.toml | Add windows-pipes feature that enables dependent crate features. |
| .github/workflows/build-datadog-serverless-compat.yml | Enable windows-pipes feature for Windows build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
46477af to
b63695a
Compare
What does this PR do?
Motivation
Describe how to test/QA your changes