Skip to content

fix(dogstatsd): Move Windows Named Pipes into a Cargo Feature#70

Merged
Lewis-E merged 9 commits intomainfrom
lewis/SVLS-8512/add-feature
Feb 12, 2026
Merged

fix(dogstatsd): Move Windows Named Pipes into a Cargo Feature#70
Lewis-E merged 9 commits intomainfrom
lewis/SVLS-8512/add-feature

Conversation

@Lewis-E
Copy link
Copy Markdown
Contributor

@Lewis-E Lewis-E commented Feb 5, 2026

What does this PR do?

Motivation

  • AWS/non-windows can exclude this code at the build level

Describe how to test/QA your changes

  • CI success for windows build + existing unit tests

@Lewis-E Lewis-E requested review from a team as code owners February 5, 2026 18:17
@Lewis-E Lewis-E requested review from duncanista and duncanpharvey and removed request for a team February 5, 2026 18:17
@Lewis-E Lewis-E marked this pull request as draft February 5, 2026 18:17
@Lewis-E Lewis-E force-pushed the lewis/SVLS-8512/add-feature branch from 19cf951 to 58b6166 Compare February 5, 2026 18:32
@Lewis-E Lewis-E marked this pull request as ready for review February 5, 2026 18:32
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be missing the field to be marked as a feature in the constructor of dogstatsd?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite LLM 2-shotted :)

Copy link
Copy Markdown
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the dogstatsd side, left a comment – not sure if you need the feature on the other crates? But I really don't understand how and where those products are used

@Lewis-E Lewis-E force-pushed the lewis/SVLS-8512/add-feature branch from 901ff28 to c9f6a91 Compare February 5, 2026 19:55
Copy link
Copy Markdown
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the dogstatsd side

@duncanista duncanista requested a review from Copilot February 6, 2026 18:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves Windows named-pipe support behind an explicit windows-pipes Cargo feature so non-Windows/AWS builds can exclude named-pipe code (and related Tokio features) at compile time.

Changes:

  • Added windows-pipes feature flags and updated #[cfg(...)] guards across crates/tests.
  • Reduced default Tokio features in dogstatsd, enabling io-util only when windows-pipes is enabled.
  • Updated Windows CI build for datadog-serverless-compat to build with --features windows-pipes.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
crates/dogstatsd/tests/integration_test.rs Gate named-pipe tests/imports and config fields behind windows-pipes.
crates/dogstatsd/src/dogstatsd.rs Gate named-pipe transport types/logic behind windows-pipes.
crates/dogstatsd/Cargo.toml Add windows-pipes feature; move tokio/io-util behind feature.
crates/datadog-trace-agent/tests/integration_test.rs Gate named-pipe test/helpers and config fields behind windows-pipes.
crates/datadog-trace-agent/tests/common/helpers.rs Gate named-pipe helper behind windows-pipes.
crates/datadog-trace-agent/src/trace_processor.rs Conditionally include Windows pipe config fields in unit-test config.
crates/datadog-trace-agent/src/mini_agent.rs Gate named-pipe server import/serve logic behind windows-pipes and adjust config handling.
crates/datadog-trace-agent/src/config.rs Gate Windows pipe config fields/env parsing behind windows-pipes (and test).
crates/datadog-trace-agent/Cargo.toml Introduce windows-pipes feature flag.
crates/datadog-serverless-compat/src/main.rs Gate reading/passing named-pipe config behind windows-pipes.
crates/datadog-serverless-compat/Cargo.toml Add windows-pipes feature that enables dependent crate features.
.github/workflows/build-datadog-serverless-compat.yml Enable windows-pipes feature for Windows build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/datadog-trace-agent/src/mini_agent.rs Outdated
Comment thread crates/dogstatsd/src/dogstatsd.rs
Comment thread crates/datadog-trace-agent/src/mini_agent.rs
Comment thread crates/datadog-trace-agent/src/config.rs Outdated
@duncanista duncanista changed the title Move Windows Named Pipes into a Cargo Feature fix(dogstatsd): Move Windows Named Pipes into a Cargo Feature Feb 10, 2026
@Lewis-E Lewis-E force-pushed the lewis/SVLS-8512/add-feature branch from 46477af to b63695a Compare February 11, 2026 22:14
@Lewis-E Lewis-E merged commit 086c937 into main Feb 12, 2026
26 checks passed
@Lewis-E Lewis-E deleted the lewis/SVLS-8512/add-feature branch February 12, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants