fix: update libdatadog references, set hostname to empty string for trace stats#71
Merged
duncanpharvey merged 5 commits intomainfrom Feb 10, 2026
Merged
Conversation
duncanista
approved these changes
Feb 9, 2026
kathiehuang
approved these changes
Feb 9, 2026
| } | ||
| }; | ||
|
|
||
| // Retries are handled internally by SendData::send() |
Contributor
There was a problem hiding this comment.
How did you realize retries are now handled internally by SendData?
Collaborator
Author
There was a problem hiding this comment.
I was reviewing the PR in libdatadog with the breaking change and noticed the send_with_retry method. feat(sidecar)!: introduce TraceData to unify text and binary data
Digging further I found that this retry logic was added some time ago in May 2024! I added a link to this PR in the description for additional context. Add retry logic to trace_utils::SendData
apiarian-datadog
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SendDatafor retriesMotivation
When hostname is sent on trace metrics it results in ephemeral instances from Azure Functions populating as hosts in the Infrastructure List.
https://datadoghq.atlassian.net/browse/SVLS-8520
Additional Notes
libdd_trace_utils::send_data::SendData: std::clone::Clone. This was originally added for retrying failed trace flushes to Datadog but since retry logic was added toSendDatasince then we can remove it.Describe how to test/QA your changes