Skip to content

Simplify RC mocked responses mapping logic#1250

Merged
smola merged 2 commits intomainfrom
smola/rc-mock-refactor
Jun 15, 2023
Merged

Simplify RC mocked responses mapping logic#1250
smola merged 2 commits intomainfrom
smola/rc-mock-refactor

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Jun 8, 2023

Description

Simplify RC mocked responses mapping logic

Motivation

Reviewer checklist

  • If this PR modify anything else than strictly the default scenario, then remove the run-default-scenario label
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follows the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Temove run-default-scenario label to run all scenarios (more info)

Once your PR is reviewed, you can merge it ! ❤️

@smola smola force-pushed the smola/rc-mock-refactor branch from ba9ad14 to 63d9361 Compare June 8, 2023 12:45
@smola smola marked this pull request as ready for review June 9, 2023 07:34
@smola smola requested a review from a team as a code owner June 9, 2023 07:34
@smola smola merged commit 840e71c into main Jun 15, 2023
@smola smola deleted the smola/rc-mock-refactor branch June 15, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants