parametric: enable Go for partial flushing and add additional test#1329
Merged
katiehockman merged 17 commits intomainfrom Aug 8, 2023
Merged
parametric: enable Go for partial flushing and add additional test#1329katiehockman merged 17 commits intomainfrom
katiehockman merged 17 commits intomainfrom
Conversation
2b1b099 to
f987db4
Compare
c0742f5 to
3969c65
Compare
brettlangdon
reviewed
Aug 3, 2023
brettlangdon
reviewed
Aug 3, 2023
brettlangdon
approved these changes
Aug 3, 2023
Kyle-Verhoog
reviewed
Aug 3, 2023
Member
There was a problem hiding this comment.
(non-blocking-nit) can we add the @released decorator for the tests? This was recently added in #1442.
Example:
system-tests/tests/parametric/test_tracer.py
Lines 45 to 47 in e80bd2a
knusbaum
approved these changes
Aug 3, 2023
ddyurchenko
approved these changes
Aug 4, 2023
…ts to fail. Inadvertently this bug allowed the 'default=ON' test to pass, so that is now being skipped since the default is actually OFF
cbeauchesne
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables
golangfor partial flushing tests.Adds additional partial flushing test to verify the behavior of
DD_TRACE_PARTIAL_FLUSH_ENABLED.There is a new test which ensures that partial flushing doesn't trigger if
DD_TRACE_PARTIAL_FLUSH_ENABLED = "false"which passes for Go and Python, but doesn't actually disable the feature for .NET. This has been marked as a bug in the test file.Motivation
Partial flushing is now supported in dd-trace-go on main. The additional tests should ensure that there is language consistency with the usage of
DD_TRACE_PARTIAL_FLUSH_ENABLED.Reviewer checklist
run-all-scenarioslabel (more info).Workflow
Once your PR is reviewed, you can merge it! ❤️