Skip to content

Implement OTel smoke tests in Java library#1344

Merged
PerfectSlayer merged 2 commits intomainfrom
bbujon/parametric-otel-java
Aug 16, 2023
Merged

Implement OTel smoke tests in Java library#1344
PerfectSlayer merged 2 commits intomainfrom
bbujon/parametric-otel-java

Conversation

@PerfectSlayer
Copy link
Copy Markdown
Contributor

@PerfectSlayer PerfectSlayer commented Jul 4, 2023

Description

Implement OTel smoke tests in Java spring-boot default library.

Motivation

Get smoke tests covered for OTel GA.

Reviewer checklist

  • If this PR modifies anything else than strictly the default scenario, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

@PerfectSlayer PerfectSlayer requested review from a team as code owners July 4, 2023 09:41
@PerfectSlayer PerfectSlayer added the java Pull requests that update Java code label Jul 4, 2023
@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from d5505fd to 4d4a7d8 Compare July 4, 2023 09:44
smola
smola approved these changes Jul 4, 2023
View reviewed changes
Comment thread tests/apm_tracing_e2e/test_otel.py
cbeauchesne
cbeauchesne requested changes Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing on CI ? https://github.com/DataDog/system-tests/actions/runs/5453236715/jobs/9921821697?pr=1344#step:16:113

@PerfectSlayer PerfectSlayer marked this pull request as draft July 5, 2023 07:59
@PerfectSlayer
Copy link
Copy Markdown
Contributor Author

PerfectSlayer commented Jul 5, 2023 •
edited
Loading

Failing on CI ?

Yes sorry, it is expected to be a draft until I get things sorted out...
I need to find why backend did not receive my traces first:
ValueError: Backend did not provide logs: /api/v2/logs/events. Status is 503.

@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from 4d4a7d8 to 7033bd9 Compare July 5, 2023 11:50
@PerfectSlayer PerfectSlayer marked this pull request as ready for review July 6, 2023 06:11
@PerfectSlayer PerfectSlayer requested a review from cbeauchesne July 6, 2023 06:45
cbeauchesne
cbeauchesne requested changes Jul 6, 2023
View reviewed changes
Comment thread utils/build/docker/java/spring-boot.Dockerfile Outdated
@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from 4c43424 to e38734f Compare July 6, 2023 10:53
@cbeauchesne
Copy link
Copy Markdown
Collaborator

cbeauchesne commented Jul 7, 2023

it's failing on CI : https://github.com/DataDog/system-tests/actions/runs/5477146404/jobs/9975765629?pr=1344

It may be a backend issue ?

@PerfectSlayer
Copy link
Copy Markdown
Contributor Author

PerfectSlayer commented Jul 7, 2023

It may be a backend issue ?

Good question. Any idea how to troubleshoot this part?

@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch 2 times, most recently from fa74adc to fb6a9b0 Compare July 7, 2023 11:43
@cbeauchesne
Copy link
Copy Markdown
Collaborator

cbeauchesne commented Jul 18, 2023

Good question. Any idea how to troubleshoot this part?

Actually, it's not related to your PR. Ok for merging(sorry for the delay).

@cbeauchesne
Copy link
Copy Markdown
Collaborator

cbeauchesne commented Aug 8, 2023

@PerfectSlayer do you need anything to merge this PR ?

@PerfectSlayer
Copy link
Copy Markdown
Contributor Author

PerfectSlayer commented Aug 9, 2023 •
edited
Loading

Not really. At the time I tried it, I had issue with backend errors.
I will need to check if it is up-to-date (with tracer and system-tests) and give it another try.
Maybe next week at it is R&D week for our team right now.

EDIT: I remember having some application key issue too. Maybe related to its permission. I will need some time to check this too.

@PerfectSlayer PerfectSlayer force-pushed the bbujon/parametric-otel-java branch from fb6a9b0 to c51019c Compare August 11, 2023 11:29
@PerfectSlayer PerfectSlayer merged commit 4424ca7 into main Aug 16, 2023
@PerfectSlayer PerfectSlayer deleted the bbujon/parametric-otel-java branch August 16, 2023 07:55
@smola smola mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@bantonsson bantonsson bantonsson approved these changes

@cbeauchesne cbeauchesne cbeauchesne approved these changes

+1 more reviewer

@DDJavierSantos DDJavierSantos DDJavierSantos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

java Pull requests that update Java code run-all-scenarios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PerfectSlayer @cbeauchesne @smola @bantonsson @DDJavierSantos