Skip to content

new integrations db weblog and related tests#1410

Merged
robertomonteromiguel merged 65 commits intomainfrom
robertomonteromiguel/integrations_db_scenario
Sep 8, 2023
Merged

new integrations db weblog and related tests#1410
robertomonteromiguel merged 65 commits intomainfrom
robertomonteromiguel/integrations_db_scenario

Conversation

@robertomonteromiguel
Copy link
Copy Markdown
Collaborator

@robertomonteromiguel robertomonteromiguel commented Jul 14, 2023

Description

Add new tests to check database integrations and generated spans

Motivation

A new way to check the status of the span generated on database integrations. We could replace the "status tab" of the current manual csv by the feature parity dashboard with the results of the current tests.

Check csv: https://docs.google.com/spreadsheets/d/1qm3B0tJ-gG11j_MHoEd9iMXf4_DvWAGCLwmBhWCxbA8/edit#gid=623219645

Check document: https://datadoghq.atlassian.net/wiki/spaces/APM/pages/2357395856/Span+attributes

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • If this PR modifies anything else than strictly the default scenario, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

Comment thread tests/integrations/test_db_integrations_sql.py Outdated
Comment thread utils/_context/containers.py Outdated
Comment thread utils/build/build.sh Outdated
@robertomonteromiguel robertomonteromiguel requested a review from a team September 8, 2023 07:06
@robertomonteromiguel robertomonteromiguel requested review from a team as code owners September 8, 2023 07:06
@robertomonteromiguel robertomonteromiguel merged commit a47519e into main Sep 8, 2023
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/integrations_db_scenario branch September 8, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants