Skip to content

parametric: add version checking support, use latest version of each library#1445

Closed
Kyle-Verhoog wants to merge 1 commit intomainfrom
kylev/better-parametric-versions
Closed

parametric: add version checking support, use latest version of each library#1445
Kyle-Verhoog wants to merge 1 commit intomainfrom
kylev/better-parametric-versions

Conversation

@Kyle-Verhoog
Copy link
Copy Markdown
Member

@Kyle-Verhoog Kyle-Verhoog commented Jul 28, 2023

Update parametric test library factories to declare and use a custom tracer version so that specific versions of the library can be validated.

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

@cbeauchesne
Copy link
Copy Markdown
Collaborator

already addressed thank to the ddtrace_install scripts.

@cbeauchesne cbeauchesne closed this Sep 5, 2024
@cbeauchesne cbeauchesne deleted the kylev/better-parametric-versions branch September 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants