Skip to content

Fix bug in telemetry message-batch support#1447

Merged
pawelchcki merged 1 commit intomainfrom
andrew/fix-message-batch-bug
Jul 31, 2023
Merged

Fix bug in telemetry message-batch support#1447
pawelchcki merged 1 commit intomainfrom
andrew/fix-message-batch-bug

Conversation

@andrewlock
Copy link
Copy Markdown
Member

Description

Fixes a bug in the messag-bach support previously implemented in #1411

Motivation

The condition is the wrong way round 🤦‍♂️

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

@andrewlock andrewlock added run-all-scenarios bug Something isn't working and removed run-all-scenarios labels Jul 31, 2023
@andrewlock andrewlock marked this pull request as ready for review July 31, 2023 11:39
@andrewlock andrewlock requested a review from a team as a code owner July 31, 2023 11:39
@pawelchcki pawelchcki merged commit 0b2e675 into main Jul 31, 2023
@pawelchcki pawelchcki deleted the andrew/fix-message-batch-bug branch July 31, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working run-all-scenarios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants