Telemetry test fixes#1448
Merged
andrewlock merged 6 commits intomainfrom Aug 3, 2023
Merged
Conversation
- Reporting disabled products is acceptable in this scenario - appsec_enabled must also be explicitly set otherwise it's not honoured
- Removed TELEMETRY_MESSAGE_BATCH_EVENT_ORDER scenario as decided it's not required - Add test that message-batching is being used
The app-started event should be the first message in a message-batch
04a031d to
b0afe12
Compare
Member
Author
|
AFAICT the failing tests are unrelated to this change (the python tests were failing previously, the otel tests are a 429 from the backend, and the node tests were dsm-related |
smola
approved these changes
Aug 1, 2023
pawelchcki
approved these changes
Aug 2, 2023
Collaborator
pawelchcki
left a comment
There was a problem hiding this comment.
Looks good to me but - it could use a second look from @DataDog/telemetry-and-analytics
paullegranddc
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TELEMETRY_MESSAGE_BATCH_EVENT_ORDERscenariotelemetry_app_started_products_disabledscenarioproductsobject is provided onapp-startedapp-startedwithmessage-batchapp-startedshould be the first message in the first batchDD_TELEMETRY_METRICS_COLLECTION_ENABLEDis not the correct variableMotivation
After discussing with @mehulsonowal, this addresses a number of bugs and changes
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info).build-some-imagelabel is present