Skip to content

replace HttpOnly=true with HttpOnly#1450

Merged
DDJavierSantos merged 2 commits intomainfrom
jsantos/httponly_fix
Aug 1, 2023
Merged

replace HttpOnly=true with HttpOnly#1450
DDJavierSantos merged 2 commits intomainfrom
jsantos/httponly_fix

Conversation

@DDJavierSantos
Copy link
Copy Markdown
Contributor

Description

Replace HttpOnly=true with HttpOnly in the vulnerability tests for HttpOnly Cookie

Motivation

HttpOnly is meant to be used as a flag, not as name value pair

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

@DDJavierSantos DDJavierSantos requested review from a team as code owners August 1, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants