Skip to content

Retry when hitting backend API rate limit#1451

Merged
smola merged 2 commits intomainfrom
smola/backend-rate-limit
Aug 2, 2023
Merged

Retry when hitting backend API rate limit#1451
smola merged 2 commits intomainfrom
smola/backend-rate-limit

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Aug 1, 2023

Description

When we hit the rate limit (HTTP 429), retry after the time specified in the response. This does not count toward the number of retries based on other criteria.

Motivation

Example of failed job: https://github.com/DataDog/system-tests/actions/runs/5733958512/job/15539438714

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

When we hit the rate limit (HTTP 429), retry after the time specified in
the response. This does not count toward the number of retries based on
other criteria.
@smola smola force-pushed the smola/backend-rate-limit branch from 2874940 to 1a42231 Compare August 1, 2023 08:32
@smola smola marked this pull request as ready for review August 2, 2023 08:15
@smola smola requested a review from a team as a code owner August 2, 2023 08:15
@smola smola merged commit 98bf5db into main Aug 2, 2023
@smola smola deleted the smola/backend-rate-limit branch August 2, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants