Skip to content

[Java][Payara] Disable Hazelcast's phone home#1457

Merged
smola merged 2 commits intomainfrom
smola/payara-hazelcast-phonehome
Aug 4, 2023
Merged

[Java][Payara] Disable Hazelcast's phone home#1457
smola merged 2 commits intomainfrom
smola/payara-hazelcast-phonehome

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Aug 4, 2023

Description

See https://docs.hazelcast.com/hazelcast/lat/phone-homes These call home calls can fail, leading to confusing errors in the logs and extra spans.

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

See https://docs.hazelcast.com/hazelcast/lat/phone-homes
These call home calls can fail, leading to confusing errors in the logs
and extra spans.
@smola smola added the java Pull requests that update Java code label Aug 4, 2023
@smola smola marked this pull request as ready for review August 4, 2023 07:22
@smola smola requested review from a team as code owners August 4, 2023 07:22
@smola smola requested a review from DDJavierSantos August 4, 2023 07:22
Comment thread utils/build/docker/java/spring-boot-payara.Dockerfile Outdated
Comment thread utils/build/docker/java/spring-boot-payara.Dockerfile Outdated
@smola smola merged commit 464667b into main Aug 4, 2023
@smola smola deleted the smola/payara-hazelcast-phonehome branch August 4, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants