Skip to content

Add telemetry metric tests#1461

Merged
andrewlock merged 2 commits intomainfrom
andrew/telemetry-metrics-v2
Aug 21, 2023
Merged

Add telemetry metric tests#1461
andrewlock merged 2 commits intomainfrom
andrew/telemetry-metrics-v2

Conversation

@andrewlock
Copy link
Copy Markdown
Member

Description

Adds a test for telemetry metrics. Currently only enabled for .NET, as I'm not sure what other teams have implemented these yet.

This test is necessarily quite slow, as we need to make sure we have had at least one aggregation period (10s). Waiting for 2 periods to avoid flake. Unfortunately the period is fixed at 10s by design (as this is a global setting per-metric in the backend) so can't be safely reduced for testing purposes.

There were already some ASM tests for metrics, so this extracts the logic already used there and shares it in the library interfaces

Motivation

We want to add system tests for telemetry features

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com

@andrewlock andrewlock force-pushed the andrew/telemetry-metrics-v2 branch 2 times, most recently from ee9d44b to 8e3d2ac Compare August 4, 2023 16:49
@smola
Copy link
Copy Markdown
Member

smola commented Aug 7, 2023

@andrewlock Lint was failing, I pushed the fix (run ./format.sh).

@andrewlock andrewlock force-pushed the andrew/telemetry-metrics-v2 branch from 41fe02d to 8fd0c46 Compare August 16, 2023 13:13
@andrewlock andrewlock marked this pull request as ready for review August 18, 2023 13:16
@andrewlock andrewlock requested review from a team as code owners August 18, 2023 13:16
@andrewlock andrewlock force-pushed the andrew/telemetry-metrics-v2 branch from 8fd0c46 to 9d5ed08 Compare August 21, 2023 09:48
@andrewlock andrewlock merged commit eaa6f00 into main Aug 21, 2023
@andrewlock andrewlock deleted the andrew/telemetry-metrics-v2 branch August 21, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants