Merged
Conversation
ae8b77e to
49a3b31
Compare
422bd83 to
4ca1929
Compare
f7c7c55 to
160df6d
Compare
160df6d to
3d0cd85
Compare
cbeauchesne
requested changes
Aug 16, 2023
LotharSee
added a commit
that referenced
this pull request
Aug 16, 2023
cbeauchesne
requested changes
Aug 16, 2023
LotharSee
added a commit
that referenced
this pull request
Aug 16, 2023
a845c0d to
5a46076
Compare
5a46076 to
ac1d56e
Compare
cbeauchesne
requested changes
Aug 17, 2023
cbeauchesne
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
uniqueness_exceptionsvariableget_sampling_decisionfunction signature/sample_rate_route/*isn't implemented in any of the Rails nor Sinatra app.Commits can be reviewed independently.
Motivation
I'm working on adding additional sampling tests cases to the suite. I'm starting with preliminary minor cleanups before opening PRs with the new logic.
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info).build-some-imagelabel is present