Skip to content

Cleanup sampling test cases#1464

Merged
LotharSee merged 6 commits intomainfrom
benjamin/cleanup-sampling-tests
Aug 18, 2023
Merged

Cleanup sampling test cases#1464
LotharSee merged 6 commits intomainfrom
benjamin/cleanup-sampling-tests

Conversation

@LotharSee
Copy link
Copy Markdown
Contributor

@LotharSee LotharSee commented Aug 7, 2023

Description

  • Remove unused uniqueness_exceptions variable
  • Simplify get_sampling_decision function signature
  • Disable Ruby tests, given that /sample_rate_route/* isn't implemented in any of the Rails nor Sinatra app.
    Commits can be reviewed independently.

Motivation

I'm working on adding additional sampling tests cases to the suite. I'm starting with preliminary minor cleanups before opening PRs with the new logic.

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@LotharSee LotharSee force-pushed the benjamin/cleanup-sampling-tests branch from ae8b77e to 49a3b31 Compare August 7, 2023 11:00
@LotharSee LotharSee force-pushed the benjamin/cleanup-sampling-tests branch from 422bd83 to 4ca1929 Compare August 7, 2023 16:22
@LotharSee LotharSee changed the title Benjamin/cleanup sampling tests Cleanup sampling test cases Aug 7, 2023
@LotharSee LotharSee marked this pull request as ready for review August 7, 2023 18:15
@LotharSee LotharSee requested a review from a team as a code owner August 7, 2023 18:15
@LotharSee LotharSee marked this pull request as draft August 7, 2023 21:43
@LotharSee LotharSee force-pushed the benjamin/cleanup-sampling-tests branch from f7c7c55 to 160df6d Compare August 7, 2023 22:39
@LotharSee LotharSee force-pushed the benjamin/cleanup-sampling-tests branch from 160df6d to 3d0cd85 Compare August 7, 2023 22:59
@LotharSee LotharSee marked this pull request as ready for review August 8, 2023 12:31
Comment thread tests/test_sampling_rates.py Outdated
Comment thread tests/test_sampling_rates.py Outdated
Comment thread tests/test_sampling_rates.py
Comment thread tests/test_sampling_rates.py Outdated
@LotharSee LotharSee force-pushed the benjamin/cleanup-sampling-tests branch from a845c0d to 5a46076 Compare August 16, 2023 12:38
@LotharSee LotharSee force-pushed the benjamin/cleanup-sampling-tests branch from 5a46076 to ac1d56e Compare August 16, 2023 16:16
@LotharSee LotharSee requested a review from cbeauchesne August 16, 2023 17:27
Comment thread tests/test_sampling_rates.py Outdated
Comment thread tests/test_sampling_rates.py Outdated
@LotharSee LotharSee requested a review from cbeauchesne August 17, 2023 12:11
@LotharSee LotharSee merged commit 0af5245 into main Aug 18, 2023
@LotharSee LotharSee deleted the benjamin/cleanup-sampling-tests branch August 18, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants