Test for RC client extra_services field#1470
Merged
Conversation
cbeauchesne
requested changes
Aug 18, 2023
| interfaces.library.validate_remote_configuration(validator=validate) | ||
|
|
||
|
|
||
| @released(cpp="?", dotnet="2.36.0", golang="?", java="?", php_appsec="?", python="?", ruby="?", nodejs="?") |
Collaborator
There was a problem hiding this comment.
Could you use new manifest files 🙏
| class Test_RemoteConfigurationExtraServices: | ||
| """Tests that extra services are sent in the RC message""" | ||
|
|
||
| remote_config_is_sent = False |
|
|
||
| return True | ||
|
|
||
| interfaces.library.wait_for(remote_config_asm_extra_services_available, timeout=30) |
Collaborator
There was a problem hiding this comment.
wait_for function must be in the setup. At this point, the weblog container is removed.
cbeauchesne
reviewed
Aug 18, 2023
robertpi
force-pushed
the
robert/asm/rc-extra-services-tests
branch
from
92c5826 to
87a9c93
Compare
robertpi
force-pushed
the
robert/asm/rc-extra-services-tests
branch
2 times, most recently
from
c631137 to
8466202
Compare
Collaborator
|
Don't worry about the conflict, I'll handle it before doing the review |
robertpi
force-pushed
the
robert/asm/rc-extra-services-tests
branch
2 times, most recently
from
d54f920 to
ccf3324
Compare
Member
Author
Too late! (Well, needed to do it to get the CI to run). |
cbeauchesne
approved these changes
Sep 6, 2023
robertpi
force-pushed
the
robert/asm/rc-extra-services-tests
branch
from
4268ef8 to
c85ee10
Compare
robertpi
force-pushed
the
robert/asm/rc-extra-services-tests
branch
from
c85ee10 to
c733ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checks that the extra_services tag is correctly populated by the remote config client.
Motivation
This feature will be used to help give any fake services that appear the correct status.
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info).build-some-imagelabel is present