Skip to content

Include telemetry 'distributions' schema#1473

Merged
iunanua merged 2 commits intomainfrom
igor/telemetry_distributions_schema
Aug 9, 2023
Merged

Include telemetry 'distributions' schema#1473
iunanua merged 2 commits intomainfrom
igor/telemetry_distributions_schema

Conversation

@iunanua
Copy link
Copy Markdown
Contributor

@iunanua iunanua commented Aug 8, 2023

Description

Include telemetry v1 and v2 "distributions" request payload schema files.

This payload will generate a distribution type metric in org2.
This schema is similar to the generate-metrics payload, but the series' points differ.

Instead of a list of [[timetamp, point]], you should send a list of points [point] representing the values your metric took

Example of a "distributions" request payload:

{
  "request_type": "distributions",
  "payload": {
    "namespace": "tracers",
    "series": [
        {
            "metric": "test.dist",
            "points": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
            "common": false
        }
    ]
  }
}

Motivation

Appsec Waf telemetry metrics can include distribution type metrics like waf.duration and waf.duration_ext.

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@iunanua iunanua marked this pull request as ready for review August 8, 2023 14:05
@iunanua iunanua requested a review from a team as a code owner August 8, 2023 14:05
@iunanua iunanua merged commit 68da674 into main Aug 9, 2023
@iunanua iunanua deleted the igor/telemetry_distributions_schema branch August 9, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants