Skip to content

fix(remote-config): Disable Remote Config in the system-tests agents by default#1480

Merged
BaptisteFoy merged 1 commit intomainfrom
baptiste.foy/rcm/add-staging-roots
Aug 10, 2023
Merged

fix(remote-config): Disable Remote Config in the system-tests agents by default#1480
BaptisteFoy merged 1 commit intomainfrom
baptiste.foy/rcm/add-staging-roots

Conversation

@BaptisteFoy
Copy link
Copy Markdown
Contributor

@BaptisteFoy BaptisteFoy commented Aug 9, 2023

Description

As we enable Remote Config by default in the agent, this means it'd get enabled by default in system-tests agents too by default. Though, these tests don't need RC and as they can either be ran on staging or prod, it is better to disable RC by default than to add staging security keys where they're needed. This PR does that.

Motivation

Less errors on Remote Config side

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@BaptisteFoy BaptisteFoy marked this pull request as ready for review August 9, 2023 13:04
@BaptisteFoy BaptisteFoy requested a review from a team as a code owner August 9, 2023 13:04
@BaptisteFoy BaptisteFoy merged commit 7b551eb into main Aug 10, 2023
@BaptisteFoy BaptisteFoy deleted the baptiste.foy/rcm/add-staging-roots branch August 10, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants