Skip to content

Fix OTel e2e test#1516

Merged
songy23 merged 5 commits intomainfrom
yang.song/fix-otel-tests
Aug 22, 2023
Merged

Fix OTel e2e test#1516
songy23 merged 5 commits intomainfrom
yang.song/fix-otel-tests

Conversation

@songy23
Copy link
Copy Markdown
Member

@songy23 songy23 commented Aug 21, 2023

Description

Fix OTel log and tracing e2e test.

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@songy23 songy23 requested a review from cbeauchesne August 21, 2023 13:48
@songy23 songy23 requested a review from a team as a code owner August 21, 2023 13:48
@songy23 songy23 force-pushed the yang.song/fix-otel-tests branch from e458095 to d1f1a41 Compare August 21, 2023 13:49
@songy23 songy23 force-pushed the yang.song/fix-otel-tests branch from d1f1a41 to b2dd608 Compare August 21, 2023 15:20
@songy23 songy23 changed the title Fix OTel log e2e test Fix OTel e2e test Aug 21, 2023
@cbeauchesne cbeauchesne marked this pull request as draft August 21, 2023 16:12
Copy link
Copy Markdown
Member Author

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly the CI produced different outputs than my local runs (which ran successfully).

@songy23 songy23 marked this pull request as ready for review August 21, 2023 18:32
@songy23
Copy link
Copy Markdown
Member Author

songy23 commented Aug 21, 2023

Should be good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants