Skip to content

Enable some tests in Java#1538

Merged
jandro996 merged 6 commits intomainfrom
smola/java-xpass-round
Sep 21, 2023
Merged

Enable some tests in Java#1538
jandro996 merged 6 commits intomainfrom
smola/java-xpass-round

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Aug 29, 2023

Description

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@smola smola requested review from a team as code owners August 29, 2023 13:29
@smola smola force-pushed the smola/java-xpass-round branch from 4c1fcb8 to 85394dd Compare August 29, 2023 15:01
cbeauchesne
cbeauchesne requested changes Aug 30, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci is failing : https://github.com/DataDog/system-tests/actions/runs/6014044212/job/16313026652?pr=1538#step:14:200

@smola smola force-pushed the smola/java-xpass-round branch from 85394dd to ad46855 Compare August 30, 2023 10:54
@smola smola requested a review from cbeauchesne August 31, 2023 08:07
cbeauchesne
cbeauchesne requested changes Sep 1, 2023
View reviewed changes
Comment thread tests/appsec/test_reports.py Outdated
@smola smola force-pushed the smola/java-xpass-round branch 2 times, most recently from e64d912 to f6475e1 Compare September 1, 2023 14:35
@cbeauchesne
Copy link
Copy Markdown
Collaborator

cbeauchesne commented Sep 5, 2023

Let ma handle the conflict

cbeauchesne
cbeauchesne reviewed Sep 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, but I think it's more instability of the weblog app at startup :

https://github.com/DataDog/system-tests/actions/runs/6081999251/job/16533936071?pr=1538#step:32:27

Let me check the log

@cbeauchesne
Copy link
Copy Markdown
Collaborator

cbeauchesne commented Sep 6, 2023

Not related, waiting for #1566 to fix it.

@cbeauchesne cbeauchesne requested review from a team as code owners September 13, 2023 19:47
@cbeauchesne
Copy link
Copy Markdown
Collaborator

cbeauchesne commented Sep 13, 2023

Hopefully, it'll the last massive conflict to handle... Sorry for the trouble !

cbeauchesne
cbeauchesne requested changes Sep 14, 2023
View reviewed changes
Comment thread manifests/java.yml Outdated
spring-boot-jetty: v0.111.0
spring-boot-openliberty: v0.115.0
spring-boot-payara: missing_feature (Missing support)
spring-boot-payara: v1.7.0 # Exact version for Payara unclear
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on this one

@jandro996 jandro996 force-pushed the smola/java-xpass-round branch from 833cae6 to 14f158b Compare September 19, 2023 09:20
cbeauchesne
cbeauchesne approved these changes Sep 19, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a request change, on unused _released_java_blocking.
I approve it, you can merge it once it's removed. Don't mind about python failure, it's not related.

Comment thread tests/appsec/test_blocking_addresses.py Outdated
cbeauchesne
cbeauchesne reviewed Sep 19, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing

cbeauchesne
cbeauchesne requested changes Sep 19, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, undoing my approval, as sone scenario were missing in CI

@jandro996 jandro996 merged commit 72e7bff into main Sep 21, 2023
@jandro996 jandro996 deleted the smola/java-xpass-round branch September 21, 2023 07:13
@smola smola mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

@bantonsson bantonsson Awaiting requested review from bantonsson bantonsson is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

run-all-scenarios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smola @cbeauchesne @jandro996