Skip to content

Enable Java test: Test_StandardTagsClientIp.test_client_ip_with_appsec_event_and_vendor_headers#1614

Merged
smola merged 1 commit intomainfrom
smola/java-xpass-round2
Sep 25, 2023
Merged

Enable Java test: Test_StandardTagsClientIp.test_client_ip_with_appsec_event_and_vendor_headers#1614
smola merged 1 commit intomainfrom
smola/java-xpass-round2

Conversation

@smola
Copy link
Copy Markdown
Member

@smola smola commented Sep 21, 2023

Description

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@smola smola requested a review from a team as a code owner September 21, 2023 13:19
@cbeauchesne cbeauchesne marked this pull request as draft September 21, 2023 13:22
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converting to draft, please ping me once it's ok 👍

@smola smola force-pushed the smola/java-xpass-round2 branch from 4dcc4c6 to a0765a0 Compare September 22, 2023 06:45
@smola smola marked this pull request as ready for review September 22, 2023 11:11
@smola smola requested a review from cbeauchesne September 25, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants