update and activate remote config tests for extra services#1623
Merged
christophe-papazian merged 14 commits intomainfrom Sep 27, 2023
Merged
update and activate remote config tests for extra services#1623christophe-papazian merged 14 commits intomainfrom
christophe-papazian merged 14 commits intomainfrom
Conversation
…ultiple_services_report
…ultiple_services_report
…ultiple_services_report
…ultiple_services_report
18 tasks
christophe-papazian
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Sep 27, 2023
Implementation of RFC "Service Names - Handling Inferred (Fake) Services" - add a multiprocessing queue to config - all workers will push discovered sub-services names on the queue - main thread will pull all names and send them to agent using Remote Config - add two unit tests and update one RC test - it will also be validated by system tests DataDog/system-tests#1623 ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) - [x] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. - [x] This PR doesn't touch any of that.
robertpi
approved these changes
Sep 27, 2023
Member
robertpi
left a comment
robertpi
left a comment
There was a problem hiding this comment.
Quite a lot of noise from code cleaning, but the changes to the logic of the test seem to be an improvement.
cbeauchesne
approved these changes
Sep 27, 2023
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
christophe-papazian
deleted the
christophe-papazian/multiple_services_report
branch
tabgok
pushed a commit
to DataDog/dd-trace-py
that referenced
this pull request
Sep 28, 2023
Implementation of RFC "Service Names - Handling Inferred (Fake) Services" - add a multiprocessing queue to config - all workers will push discovered sub-services names on the queue - main thread will pull all names and send them to agent using Remote Config - add two unit tests and update one RC test - it will also be validated by system tests DataDog/system-tests#1623 ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) - [x] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from `@DataDog/security-design-and-guidance`. - [x] This PR doesn't touch any of that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test_RemoteConfigurationExtraServicesfor pythontests/remote_config/test_remote_configuration.pyand add checks intest_tracer_extra_servicesMotivation
With DataDog/dd-trace-py#6929, python tracer will implement the extra service names report feature. Once it is merged, we should activate those tests for the tracer. [merge done]
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario,run-profiling-scenario...). If this PR modifies any system-tests internal, then add therun-all-scenarioslabel (more info).build-some-imagelabel is present